Skip to content
This repository has been archived by the owner on May 11, 2023. It is now read-only.

feat: Use Benedict for better dictionary management #20

Open
thomaspinder opened this issue Mar 14, 2023 · 0 comments
Open

feat: Use Benedict for better dictionary management #20

thomaspinder opened this issue Mar 14, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@thomaspinder
Copy link
Contributor

Feature Request

When handling complex dictionary structures, Benedict makes tasks such as indexing easier. We should transition all dictionaries to use Benedict.

A clear place where this will be helpful is in selecting and updating individual parameters. In Benedict, the syntax could be as simple as

def update_param_value(self, key: str, value: jax.Array) -> None:
    self.params[key] = value

In Benedict, the key could be kernel.lengthscale whereas with regular nested dictionaries, one would have to write something more complex to index with ['kernel']['lengthscale'].

@thomaspinder thomaspinder added enhancement New feature or request good first issue Good for newcomers labels Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant