Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use long data type for Event Version #1080

Closed
jinhong- opened this issue Sep 6, 2018 · 4 comments · Fixed by #1695
Closed

Use long data type for Event Version #1080

jinhong- opened this issue Sep 6, 2018 · 4 comments · Fixed by #1695

Comments

@jinhong-
Copy link
Contributor

jinhong- commented Sep 6, 2018

For the next version of Marten, it would be good to upgrade the version for events to long instead of int. This will give streams with high event counts more room to grow

@oskardudycz
Copy link
Collaborator

I think that it's a good idea. @jeremydmiller what do you think?

@jeremydmiller
Copy link
Member

Ugh, yes, it's a good idea. Let me see if I can sneak that in right now

@jeremydmiller
Copy link
Member

@oskardudycz @jinhong- So yes and no. I'm not gonna try to tackle it right now because we don't have any clean way to generate the table delta to bump the data type from int to long. Since we're in a hurry to get to 3.0, I think this slides to 4.0. But saying that, 4.0 might come reasonably soon.

@oskardudycz
Copy link
Collaborator

oskardudycz commented Sep 26, 2018

@jeremydmiller fine for me, I can help on bringing this long version later on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants