Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation to issue templates' front matter #143

Closed
JasonEtco opened this issue Dec 21, 2022 · 0 comments · Fixed by #144
Closed

Add validation to issue templates' front matter #143

JasonEtco opened this issue Dec 21, 2022 · 0 comments · Fixed by #144
Labels
good first issue Good for newcomers

Comments

@JasonEtco
Copy link
Owner

It currently pulls in the front matter of the issue template, but doesn't assert that it has the required fields or any invalid fields. For example, if an issue template doesn't include a title front matter attribute, the Action fails because it can't render the title. That's expected, but the error message is confusing and not specific.

We should implement a check against a defined schema, to say "does this front matter match this schema". Using Joi or Zod something similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant