Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TM Player Bio not returning value for Valuation #357

Closed
JaseZiv opened this issue Jan 17, 2024 · 0 comments
Closed

TM Player Bio not returning value for Valuation #357

JaseZiv opened this issue Jan 17, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@JaseZiv
Copy link
Owner

JaseZiv commented Jan 17, 2024

From Twitter user https://twitter.com/Ismael_Haffoud:

There is an issue with tm_player_bio(). I think it doesn't retrieve the value anymore for instance:

library(worldfootballR)
packageVersion("worldfootballR")

[1] ‘0.6.5’

bio <- tm_player_bio(player_url = "https://transfermarkt.com/jude-bellingham/profil/spieler/581678")

dplyr::glimpse(bio)

Rows: 1
Columns: 18
$ player_name               <chr> "Jude Bellingham"
$ name_in_home_country      <chr> "Jude Victor William Bellingham"
$ place_of_birth            <chr> "Stourbridge"
$ height                    <dbl> 1.86
$ citizenship               <chr> "England Ireland"
$ position                  <chr> "midfield - Attacking Midfield"
$ foot                      <chr> "right"
$ current_club              <chr> "Real Madrid"
$ joined                    <chr> "2023-07-01"
$ contract_expires          <chr> "2029-06-30"
$ outfitter                 <chr> "adidas"
$ twitter                   <chr> "https://twitter.com/BellinghamJude"
$ instagram                 <chr> "[http://instagram.com/judebellingham/](https://t.co/1V7BEfFxX7)"
$ player_valuation          <dbl> NA
$ max_player_valuation      <dbl> NA
$ max_player_valuation_date <chr> NA
$ URL                       <chr> "https://transfermarkt.com/jude-bellingham/profil/spieler/581678"
$ date_of_birth             <chr> "2003-06-29"

This does in fact appear to be caused by a change in the html. I will patch a fix shortly.

@JaseZiv JaseZiv added the bug Something isn't working label Jan 17, 2024
@JaseZiv JaseZiv self-assigned this Jan 17, 2024
@JaseZiv JaseZiv closed this as completed Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant