Skip to content

Commit

Permalink
Fix linter after updating
Browse files Browse the repository at this point in the history
The linter now complains about duplicate code that
just consists of our license header and using.
Ignoring the using should fix that.

It now also checks whether a GitHub workflow has
too many permissions. We should limit those in
general to what is actually needed.

Signed-off-by: Florian Hockmann <[email protected]>
  • Loading branch information
FlorianHockmann committed Apr 24, 2024
1 parent a0cef5b commit 01d7c93
Show file tree
Hide file tree
Showing 5 changed files with 25 additions and 4 deletions.
1 change: 1 addition & 0 deletions .dependency_license
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,4 @@ JanusGraph.Net.sln, Apache-2.0
JanusGraph logomark color RGB.png, Apache-2.0
CONTRIBUTORS.txt, Apache-2.0
appsettings.json, Apache-2.0
.jscpd.json, Apache-2.0
10 changes: 8 additions & 2 deletions .github/workflows/dotnet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,17 @@ on:
types:
- published

permissions: { }

env:
NUGET_KEY: ${{ secrets.NUGET_KEY }}
NUGET_FEED: https://api.nuget.org/v3/index.json

jobs:
build:
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
permissions:
contents: read

steps:
- uses: actions/checkout@v4
Expand All @@ -55,7 +59,9 @@ jobs:
deploy:
needs: build
if: github.event_name == 'release'
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
permissions:
contents: read

steps:
- name: Download Artifact
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/license.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,13 @@ name: License Validation
on:
pull_request: { }

permissions: { }

jobs:
weasel:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
permissions:
contents: read
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
9 changes: 8 additions & 1 deletion .github/workflows/linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,16 @@ on:
pull_request: { }
push: { }

permissions: { }

jobs:
check:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
permissions:
contents: read
packages: read
# To report GitHub Actions status checks
statuses: write
steps:
- name: Checkout Code
uses: actions/checkout@v4
Expand Down
3 changes: 3 additions & 0 deletions .jscpd.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"ignore-pattern": ["using\\s.*\\;"]
}

0 comments on commit 01d7c93

Please sign in to comment.