add-github-actions #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabim777
force-pushed
the
github-actiions-ci
branch
3 times, most recently
from
79779a9
to
29691ca
Compare
nabim777
force-pushed
the
github-actiions-ci
branch
from
29691ca
to
f724ace
Compare
nabim777
force-pushed
the
github-actiions-ci
branch
4 times, most recently
from
08eda92
to
b6ae2b5
Compare
nabim777
force-pushed
the
github-actiions-ci
branch
2 times, most recently
from
9fdf29d
to
ac2bcf1
Compare
nabim777
force-pushed
the
github-actiions-ci
branch
3 times, most recently
from
e42cf74
to
8240755
Compare
SagarGi
reviewed
Aug 24, 2023
SagarGi
reviewed
Aug 24, 2023
nabim777
force-pushed
the
github-actiions-ci
branch
from
8240755
to
c067980
Compare
saw-jan
reviewed
Aug 24, 2023
saw-jan
reviewed
Aug 24, 2023
nabim777
force-pushed
the
github-actiions-ci
branch
from
f938b04
to
4980cd6
Compare
nabim777
force-pushed
the
github-actiions-ci
branch
from
4980cd6
to
7fc92ca
Compare
nabim777
force-pushed
the
github-actiions-ci
branch
5 times, most recently
from
8d39097
to
cf80869
Compare
nabim777
force-pushed
the
github-actiions-ci
branch
from
cf80869
to
1f89969
Compare
nabim777
force-pushed
the
github-actiions-ci
branch
2 times, most recently
from
4b9979c
to
de81c58
Compare
nabim777
force-pushed
the
github-actiions-ci
branch
from
de81c58
to
f173f17
Compare
SwikritiT
reviewed
Aug 29, 2023
SwikritiT
reviewed
Aug 29, 2023
readme.md
Outdated
| ``` | ||
| - After installing Bats, you can run your tests locally using the following command: | ||
| ```bash | ||
| bats tests/test_scan_command.bats |
There was a problem hiding this comment.
maybe better to not hard-code the filename incase we add other tests as well?
Suggested change
| bats tests/test_scan_command.bats | |
| bats tests/<path-to-the-test-file> |
There was a problem hiding this comment.
Can it be done this way?
bats tests/*.bats
There was a problem hiding this comment.
yes, that will work and in the future a developer can run all the bats tests without needing to know what the filename(s) are.
phil@phil-Inspiron-5468:~/git/JankariTech/expected-failures-updater$ bats tests/*.bats
✓ detect removed scenarios
✓ detect new added scenarios
2 tests, 0 failures
SwikritiT
reviewed
Aug 29, 2023
nabim777
force-pushed
the
github-actiions-ci
branch
from
82a96ed
to
d8b086b
Compare
SagarGi
reviewed
Aug 31, 2023
phil-davis
reviewed
Aug 31, 2023
Co-authored-by: Sagar Gurung <[email protected]>
phil-davis
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here ,setup of GitHub actions workflow is added to test only
Issue
#11