-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature of the closing options of the growl message #54
Comments
I like where this is heading. Configuration is great. I would want to be able to decide on a per type basis as well. Like have no timer on errors (they always stay open until closed), but allow warnings and info messages to have the standard timer, and the options outlined above as far as hover to pause and only close on clicking the close button. |
@morgenes great addition for configuration per type, thats something I forgot and is actually needed. I'll think about code structure and architecture because right now I'm not really happy with the current code. |
I'd love to be able to define global behaviors for each notification type and apply them once. For example by passing an object with defaults for each type during config, and have the directive {
'error' : {
'pauze' : 'onhover onclick',
'close' : 'onclosebutton',
'ttl' : 10000
},
'info' : {
'pauze' : 'onhover',
'close' : 'onclick',
'ttl' : 4000
},
// config-defined defaults for types with no specific settings
'default' : {
'pauze' : '',
'close' : 'onclosebutton',
'ttl' : 3000
}
} |
Is it possible at the moment to disable the close action triggered by a double click on a notification? I display links in my notifications, so the users can only click two times on them, quite annoying. ^^' |
I have the same question as @jgoux, I'm using persistent growls as navigation aids in a SPA, it would be nice to override the click-to-keep/click-to-close from the app config. |
@alonweinstein I like that API, its easy and with a couple of keywords we can define some behaviour. I'll think about it, atm the code is quite messy and could use a clean up/improvement |
Happy to help - any particular part of the code you want cleanup on? |
+1 for this one! |
CSS for disabling close on click (Proposal 2) .growl-container > .growl-item { pointer-events: none } |
@alejandr0bovino : pointer-events: none doesnot work here. Looking for any other alternatives. |
hello,
After issues #53, #51 and #49 we need standardise the way we close a growl notification. A little explanation:
Right now the growl message is shown and the counter shows how long the growl message will be visible. Then a user can click on it to keep the growl notification displayed and click on it again to remove the growl. Clicking on the close button will remove the growl message immediately.
A couple of things happen and I would like to define some flows so everything is standardised and configurable and clear.
Proposal
Possible issues
This of course limits the possibilities, but will allow for easily extending the possible pauze and close handling.
Any thoughts or comments? Input very much needed as I don't know which direction to go.
The text was updated successfully, but these errors were encountered: