Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadTheDocs build is broken #53

Closed
pllim opened this issue Aug 15, 2022 · 2 comments
Closed

ReadTheDocs build is broken #53

pllim opened this issue Aug 15, 2022 · 2 comments

Comments

@pllim
Copy link
Contributor

pllim commented Aug 15, 2022

At the time of opening this issue, the last successful build was over 3 weeks ago (July 24, 2022): https://readthedocs.org/projects/pyautogalaxy/builds/

Also see #50

astropy/astropy.github.com#491 (comment)

@Jammy2211
Copy link
Owner

This build is now successful: https://readthedocs.org/projects/pyautogalaxy/builds/

We intend to prevent releases via our biuld server if readthedocs does not build successfully - if you have a suggestion on how to do this it'd be much appreciated!

Jammy2211/PyAutoBuild#17

@pllim
Copy link
Contributor Author

pllim commented Nov 28, 2022

If you want to prevent release with failed RTD, you could run the same sphinx command that RTD runs as one of your release steps. It is in the logs:

.../bin/python -m sphinx -T -E -b html -d _build/doctrees -D language=en . _build/html

As for the RTD build itself, optional but recommended:

  1. Resolve the 57 warnings. Example log: https://readthedocs.org/api/v2/build/18753466.txt
  2. To prevent future warnings creeping back it, set RTD build to fail on warning.
  3. To prevent bad cross-linking, set nitpicky=True in docs/conf.py and fix the broken refs.
  4. To prevent bad URLs, run linkcheck once in a while (could be a cron job). There might be false positives sometimes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants