Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move install_requires from requirements.txt to setup.py #47

Open
pllim opened this issue Aug 15, 2022 · 2 comments
Open

Move install_requires from requirements.txt to setup.py #47

pllim opened this issue Aug 15, 2022 · 2 comments

Comments

@pllim
Copy link
Contributor

pllim commented Aug 15, 2022

Currently install_requires requirements are buried in a text file. Would be easier to discover if it is just done in setup.py . No reason to have file I/O overhead during setup for those entries.

Bonus: Move all that data from setup.py to setup.cfg for easier to read package info.

astropy/astropy.github.com#491 (comment)

@Jammy2211
Copy link
Owner

We are going to adopt this: #67

Would listing all requirements and optional requirements in the pyproject.toml file satisfy this issue?

@pllim
Copy link
Contributor Author

pllim commented Nov 28, 2022

Yes, since I posted this, using pyproject.toml instead of setup.cfg is now popular. As long as you don't mind pinning to a much newer version of setuptools, I think that is the way to go now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants