-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(config): display ESM errors found in config files #229
Comments
Ignore that, it's wrong (still waking up ☕ 😄) Could you put together a repro please? This is unexpected. |
You can reproduce it in I cannot reproduce in other projects, only that one. |
Thanks, I will take a look when I get a chance. In the meantime |
Done. My config file exists at Another question, does the config need deep search syntax like this or Syncpack already does it as shown in the debug logs? packages: [
'package.json',
'xiroi-apps/*/package.json',
'xiroi-packages/*/package.json',
'xiroi-packages/*/*/package.json',
], |
I'm not sure why, because |
https://github.com/xiroicat/xiroi/blob/turborepo/syncpack.config.js |
I know it is there, but syncpack did not find it and this is what needs investigation. |
I've cloned and added some logs and there is a swallowed error from cosmiconfig:
I'll leave this issue open to surface these errors as it is too vague at the moment. EDIT: In my editor I do see the same error |
Great, it works @JamieMason. Strange that my VSCode doesn't complain about ESM when my root package.json is I updated the Syncpack config to In ESM, it only needs /** @type {import("syncpack").RcFile} */
export default {
If the dependency warns the user could be helpful. Else close the issue. |
Great, glad it got sorted. Thanks @guillempuche – I'll leave this open to track surfacing errors when they happen. |
Description
I've tried the latest to releases, it doesn't sort fields as my config points in my monorepo. I don't know why.
Script
syncpack format --config syncpack.config.js
on my rootpackage.json
and output:// syncpack.config.js
Output:
Suggested Solution
scripts
should be beforedependencies
.The text was updated successfully, but these errors were encountered: