cannot distinguish declare global on AST.

[mysticatea]

What version of TypeScript are you using?

• 3.1.6

What version of typescript-estree are you using?

• 2.1.0 (typescript-eslint-parser#master)

What code were you trying to parse?

// Augmentations for the global stuff.
declare global {
}

// A namespace declaration.
declare namespace global {
}

What did you expect to happen?

typescript-estree generates different nodes because the two have different semantics.

What actually happened?

typescript-estree generates the same node:

    {
      "type": "TSModuleDeclaration",
      "id": {
        "type": "Identifier",
        "name": "global"
      },
      "body": {
        "type": "TSModuleBlock",
        "body": []
      },
      "declare": true
    }

[mysticatea]

TSGlobalAugmentationDeclaration node may be nice.

// The node that expresses `declare global {}`.
interface TSGlobalAugmentationDeclaration extends Statement {
    type: "TSGlobalAugmentationDeclaration"
    body: TSModuleBlock
}

[mysticatea]

@JamesHenry what do you think about this? I think critical if we cannot distinguish semantic on AST.

[armano2]

According to babel/typescript its: https://github.com/babel/babel/blob/master/packages/babel-types/src/definitions/typescript.js#L390

defineType("TSModuleDeclaration", {
  aliases: ["Statement", "Declaration"],
  visitor: ["id", "body"],
  fields: {
    declare: validateOptional(bool),
    global: validateOptional(bool),
    id: validateType(["Identifier", "StringLiteral"]),
    body: validateType(["TSModuleBlock", "TSModuleDeclaration"]),
  },
});

AST is not aligned it should contain global: validateOptional(bool),

https://github.com/babel/babel/blob/master/packages/babel-parser/src/plugins/typescript.js#L1046

[JamesHenry]

🎉 This issue has been resolved in version 5.3.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀