Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More system transition animators (animation controllers) #126

Closed
JakeLin opened this issue Mar 19, 2016 · 6 comments · Fixed by #154
Closed

More system transition animators (animation controllers) #126

JakeLin opened this issue Mar 19, 2016 · 6 comments · Fixed by #154

Comments

@JakeLin
Copy link
Member

JakeLin commented Mar 19, 2016

To have more system transition animations can be configured in Interface Builder.

Unlock all system built-in animations, We have SystemCubeAnimator and SystemFlipAnimator now, we can easily unlock all system built-in animations in SystemTransitionType. They all have same implementation with different parameters. Refer to http://iphonedevwiki.net/index.php/CATransition

Documents:

@tbaranes
Copy link
Member

If we already have all of them, it would be a huge work 😆
Seems we are gonna have a lot of fun!

@JakeLin
Copy link
Member Author

JakeLin commented Mar 20, 2016

@tbaranes too good to be true if we can implement all of them. I think we can do frequent releases for every one or few animators. Once we have implemented some of popular transition animators, it is good enough to use in most of transitions.

@tbaranes
Copy link
Member

Just to keep in mind: the animation SystemPageCurl could be refactored in order to use animateWithCATransition, in order words creating a new enums instead of using the enums. The result won't change but will create a breaking change, nevertheless, it will make sense.

Also, here the full list of the system animators and their implementation state:

  • Fade
  • MoveIn
  • Push
  • Reveal
  • Flip
  • Cube
  • PageCurl
  • PageUnCurl
  • RippleEffect
  • SuckEffect
  • CameraIris
  • CameraIrisHollowOpen
  • CameraIrisHollowClose
  • Rotate

That list doesn't contains the private transition, source from stackoverflow

@JakeLin
Copy link
Member Author

JakeLin commented Mar 30, 2016

Don't mind for the breaking changes for renaming SystemPageCurl, should follow the system names. 👍 for the check list.

@tbaranes
Copy link
Member

tbaranes commented Apr 2, 2016

Should we renamed that issue More system transition animators and create a new one for the custom transition animators?

Once all the PR merged, we also may make a new released since all the system ones are implemented.
What do you think? 👯

@JakeLin JakeLin changed the title More transition animators (animation controllers) More system transition animators (animation controllers) Apr 2, 2016
@JakeLin
Copy link
Member Author

JakeLin commented Apr 2, 2016

@tbaranes agree, we can release 2.2 once once we merge all your PRs, good on you. 👍

Have created a new issue for Custom transition animators (animation controllers)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants