Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jaguar_query_sqflite package to 2.2.x #50

Closed
tejainece opened this issue Jul 27, 2018 · 9 comments
Closed

Upgrade jaguar_query_sqflite package to 2.2.x #50

tejainece opened this issue Jul 27, 2018 · 9 comments
Assignees

Comments

@tejainece
Copy link
Member

No description provided.

@tejainece
Copy link
Member Author

@jaumard Could you please upgrade jaguar_query_sqflite package to 2.2.x?

One of the breaking changes is merging of Col and Field into Field. There are some minor simplifying changes too. You could use jaguar_query_postgres package for reference.

Thanks.

@jaumard
Copy link
Contributor

jaumard commented Jul 28, 2018

Sure :) let me look at this :)

@jaumard jaumard self-assigned this Jul 28, 2018
@jaumard
Copy link
Contributor

jaumard commented Jul 28, 2018

@tejainece jaguar_query has strong dependency on jaguar_query_postgres where it should be the opposite jaguar_query shouldn't know about jaguar_query_postgres at all.
jaguar_query_postgres is put as dev_dep even if not only for dev.
I say that because jaguar_query_postgres doesn't work with flutter as it use an SDK too recent for now.

@jaumard
Copy link
Contributor

jaumard commented Jul 28, 2018

Also you have change update(tableName) from update()..into(tableName) but Find and Insert didn't change, I don't think is good to have different notation, it should be align

@tejainece
Copy link
Member Author

jaguar_query_postgres is just a dev dependency. So there are some real life examples directly in the query repo. There is no actual dependence.

@tejainece
Copy link
Member Author

That change is based on how we describe it in english.

Update this table with these rows.

Insert these rows in into this table

I have fixed the Find according to your suggestions.

FInd from this table where this expression select these fields

@tejainece
Copy link
Member Author

tejainece commented Jul 28, 2018

Will also change insert statement according to your suggestions. Maybe consistency is more important that correlation with English language.

@jaumard
Copy link
Contributor

jaumard commented Jul 28, 2018

Hum in my opinion consistency is more important, even more because Insert(tableName) don't throw any error as it's a correct statement (it will probably crash at runtime)

@tejainece
Copy link
Member Author

Changed insert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants