Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

art_crop and border_crop URIs Missing from Cards #21

Closed
Bonney opened this issue May 14, 2024 · 1 comment · Fixed by #22
Closed

art_crop and border_crop URIs Missing from Cards #21

Bonney opened this issue May 14, 2024 · 1 comment · Fixed by #22

Comments

@Bonney
Copy link
Contributor

Bonney commented May 14, 2024

Hello! I am having an issue where Card objects returned from the API are missing the art_crop and border_crop image URI. All other sizes return proper URLs. See attached photo.

My guess is this is a Codable issue, although your code appears to have the proper coding keys set in the ImageUris struct.

As a test I have confirmed the direct Scryfall API returns URLs for both art and border crops that are valid, and will successfully load in a SwiftUI AsyncImage.

Screenshot 2024-05-14 at 11 47 26 AM
@Bonney
Copy link
Contributor Author

Bonney commented May 14, 2024

I actually believe I found the issue, after poking around a bit more it appears the custom coding keys are redundant and causing the issue; see my PR: #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant