Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) version search #18

Closed
wants to merge 2 commits into from
Closed

(WIP) version search #18

wants to merge 2 commits into from

Conversation

RobertRR11
Copy link
Contributor

To be honest I actually have no clue how typescript works

  • version fetching
  • version filters
  • version search (duh)
  • fallback for version fetching (maybe hardcoded json file?)
  • getting rid of flickering when updating version list

@JackDotJS
Copy link
Owner

  • fallback for version fetching (maybe hardcoded json file?)
  • getting rid of flickering when updating version list

can u elaborate on these?

@JackDotJS JackDotJS added html/css anything that largely involves ui layouts and styling basic functionality very early development stuff typescript anything that largely involves JavaScript/TypeScript code labels Apr 9, 2023
@JackDotJS JackDotJS linked an issue Apr 9, 2023 that may be closed by this pull request
@RobertRR11
Copy link
Contributor Author

fallback for version fetching (maybe hardcoded json file?)

For when Mojang API is down or any other network issue

getting rid of flickering when updating version list

Right now when you filter versions, the whole list gets removed and added again, which shifts the whole page for a very short time. This could probably be solved by just making the list a fixed height

@JackDotJS
Copy link
Owner

For when Mojang API is down or any other network issue

shouldn't we just list what versions the user has installed? assuming we're sticking with local files only for now

Right now when you filter versions, the whole list gets removed and added again, which shifts the whole page for a very short time. This could probably be solved by just making the list a fixed height

the list should already be a fixed height. otherwise, adding more items would extend the entire page instead of showing a scroll bar x)

i can't imagine why the whole page would shift if we're changing elements within an overflow element...

@RobertRR11
Copy link
Contributor Author

the list should already be a fixed height.

The list only has a max height. While the list elements are removed for the short amount of time, the list will get smaller than the max height and shift the page

@JackDotJS
Copy link
Owner

i-

image

WHY THE FUCK DID I MAKE IT A MAX HEIGHT.

@RobertRR11 RobertRR11 closed this by deleting the head repository Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
basic functionality very early development stuff html/css anything that largely involves ui layouts and styling typescript anything that largely involves JavaScript/TypeScript code
Projects
Status: 🏗 In-progress
Development

Successfully merging this pull request may close these issues.

add version search
2 participants