Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshots missing/broken on the Comments documentation page #527

Closed
Tridecatrix opened this issue Oct 16, 2024 · 5 comments
Closed

Screenshots missing/broken on the Comments documentation page #527

Tridecatrix opened this issue Oct 16, 2024 · 5 comments

Comments

@Tridecatrix
Copy link
Contributor

Tridecatrix commented Oct 16, 2024

There are clearly screenshots meant to be on this page that are missing:
Image

Links to the page online and on the Github repo:

I have tried to re-create the screenshots and make a PR accordingly, but the comments page demonstrates comments made by several different users, and I am not sure how to replicate that. If it requires using the SQL shared database feature then it really isn't worth the headache for me personally. If you can instead export the library to .bib and comments can be seen on other devices after importing the .bib on JabRef, then it might be possible for me to replicate those. In the former case I'll leave this issue to someone who is more familiar with JabRef; in latter case I'll try handle it myself.

@Siedlerchr
Copy link
Member

@Tridecatrix
Copy link
Contributor Author

Tridecatrix commented Oct 16, 2024

Hm good point, I just had a look and unfortunately if the files exist, they are not called comment- something. It doesn't help that in the Github version of the file, all it says is "broken reference". The other random selection of files I checked in that directory weren't it either.

Image

It may be quickest and easiest for @koppor to resolve this themselves as (presumably) they created the screenshots in the first place? Not a very high priority issue of course.

@koppor
Copy link
Member

koppor commented Oct 16, 2024

Fixed at be03098.

Background: We cleanup our images now and then. However, gitbook started to use image as name for all images. Thus, we overwrite some images.


Internal hints:

@koppor koppor closed this as completed Oct 16, 2024
@koppor
Copy link
Member

koppor commented Oct 16, 2024

Thank you for reporting @Tridecatrix

I have tried to re-create the screenshots and make a PR accordingly,

So happy to see that you wanted to contribute. If you have time, you could work on some other issues listed at https://github.com/JabRef/user-documentation/issues.

but the comments page demonstrates comments made by several different users,

Yes

and I am not sure how to replicate that.

Just edit the bibtex source manually. The format is comment-username for the field. Thus, no need for some shared setup 😅

@Tridecatrix
Copy link
Contributor Author

Tridecatrix commented Oct 16, 2024

Thanks for the quick response, fix and feedback! Checking a previous commit was certainly a nice solution 😅.

As for other issues, I'll see what I can do :).

@koppor koppor mentioned this issue Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants