Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update antlr task + gradle #7097

Merged
merged 7 commits into from
Nov 16, 2020
Merged

Update antlr task + gradle #7097

merged 7 commits into from
Nov 16, 2020

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Nov 14, 2020

Fixes #6431
Fixes koppor#440

I finally found the solution.
Get rid of our AntlrPlugin and follow the idea from here:
https://stackoverflow.com/a/56029522/3450689

Update to gradle 6.6 and newer is not yet possible due to openjfx/javafx-gradle-plugin#89
Make @koppor happy :)

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 14, 2020
@calixtus
Copy link
Member

Except for the unnecessary tab at the eol (I like reviewdog) and the many additional linebreaks (😁), it looks good to me - although I did not work much with groovy yet.

@Siedlerchr
Copy link
Member Author

I see that there is mac failing, will investigate that

Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, it is OK. There shouldn't be any mix of spaces and tabs.

Please fix

File contains tab characters (this is the first instance).

@Siedlerchr Siedlerchr merged commit 1dc91ca into master Nov 16, 2020
@Siedlerchr Siedlerchr deleted the updateAntlrTask branch November 16, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ADR to stick on older Gradle version 6.3
3 participants