Display deprecated fields in misc entry also in optional fields tab #4389
Conversation
Siedlerchr
added
the
status: ready-for-review
| @@ -372,7 +372,7 @@ public String getName() { | |||
| FieldName.orFields(FieldName.YEAR, FieldName.DATE)); | |||
| addAllOptional(FieldName.SUBTITLE, FieldName.TITLEADDON, FieldName.LANGUAGE, FieldName.HOWPUBLISHED, | |||
| FieldName.TYPE, FieldName.VERSION, FieldName.NOTE, FieldName.ORGANIZATION, FieldName.LOCATION, | |||
| FieldName.MONTH, FieldName.ADDENDUM, FieldName.PUBSTATE, FieldName.DOI, FieldName.EPRINT, | |||
| FieldName.DATE, FieldName.MONTH, FieldName.YEAR, FieldName.ADDENDUM, FieldName.PUBSTATE, FieldName.DOI, FieldName.EPRINT, | |||
There was a problem hiding this comment.
Why do you add Date and Year here? They fields are already in the required tab?
There was a problem hiding this comment.
See biblatex manual, 2.1.1 misc entry type.
It's listed both in required and optional fields. Either it's an error in the spec or there is some reason why this is double?
Required felds: author/editor, title, year/date
Optional felds: subtitle, titleaddon, language, howpublished,
type, version, note, organization, location, date, month, year,
addendum, pubstate, doi, eprint, eprintclass, eprinttype, url,
urldate
There was a problem hiding this comment.
Yes, that looks to me like an error in manual.
There was a problem hiding this comment.
It was confirmed as an error, created an issue at biblatex repo.
| @@ -25,6 +25,6 @@ public OptionalFields2Tab(BibDatabaseContext databaseContext, SuggestionProvider | |||
|
|
|||
| @Override | |||
| protected Collection<String> determineFieldsToShow(BibEntry entry, EntryType entryType) { | |||
| return entryType.getSecondaryOptionalNotDeprecatedFields(); | |||
| return entryType.getSecondaryOptionalFields(); | |||
There was a problem hiding this comment.
Doesn't this now also shows the deprecated fields in the second optional pane?
Fixes #4388
The reason for the original code was to fix #3046, however I couldn't reproduce the issue mentioned there after I removed it. The custom entry types dialog effectively prevents you from adding from the same field twice.