Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unprotect selection #9950

Closed
mpatas opened this issue May 24, 2023 · 5 comments · Fixed by #9968
Closed

Unprotect selection #9950

mpatas opened this issue May 24, 2023 · 5 comments · Fixed by #9968
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. ui

Comments

@mpatas
Copy link

mpatas commented May 24, 2023

When one right clicks on some selected text in a field, one has a choice of "Protect selection" (in submenu "Protect terms") that puts "{" before the selection and "}" after it. Perhaps it would be worth to have an opposite action, "Unprotect selection", that would remove all such "protections"? It would be especially convenient when, the imported record has protected words in all caps, and one wants to use, for example, title case.

@Siedlerchr
Copy link
Member

Hi, in the Cleanup Dialog under Quality-> Field formatters there you can add "Unprotect terms" as action.

But I agree with you that it should be available in the right click menu

@BeeJay28
Copy link
Contributor

BeeJay28 commented Jun 1, 2023

I am currently working on a solution for this, but I am not as acquainted with the product itself. And since googling didn't help me yet, I would like to ask, what exact purpose and effect does "protecting text" have? If possible, please provide both the effect for the user, as well as technical effects that happen when a user chooses to protect a piece of text. Thank you

@alchimos
Copy link
Contributor

alchimos commented Jun 1, 2023

Hi, I might have it done already but would leave it to @BeeJay28 for his timing.

Just one question: what about icon?
I don't see a strikethrough CODE_BRACES icon in the kordamp material design. Should we leave out icon for this action?

@BeeJay28
Copy link
Contributor

BeeJay28 commented Jun 1, 2023

Hi, I might have it done already but would leave it to @BeeJay28 for his timing.

Just one question: what about icon? I don't see a strikethrough CODE_BRACES icon in the kordamp material design. Should we leave out icon for this action?

That's very kind, feel free to give feedback to my solution once it's ready ^^.
I was wondering about the icon thing too though.

@Siedlerchr
Copy link
Member

Thanks both for your interest in this issue.
Some background: In LaTeX the casing of the references is normally defined by the style. Howeverr, you can wrap text inside a pair of curly braces to keep the casing, for example when you have authors that are organisatizons e.g. European Space Agency would be protected to keep the casing and to prevent it beeing abbreviated.

For the icon: Either no icon or maybe another one from the variants of unlock/open lock?

PS: For the next time: Please only choose issues that have been labeled and approved by the JabRef Team or one from the various https://github.com/JabRef/jabref/projects?query=is%3Aopen

@Siedlerchr Siedlerchr added ui good first issue An issue intended for project-newcomers. Varies in difficulty. labels Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. ui
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants