Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Office 2007 bibliography source with LCID #9699

Closed
AkiraVoid opened this issue Mar 23, 2023 · 8 comments · Fixed by #9729
Closed

Export Office 2007 bibliography source with LCID #9699

AkiraVoid opened this issue Mar 23, 2023 · 8 comments · Fixed by #9729
Assignees
Labels
export / save FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. microsoft office

Comments

@AkiraVoid
Copy link

Is your suggestion for improvement related to a problem? Please describe.
By default, JabRef will export Office 2007 bibliography source with all entries' LCID set to en-US, which is not convenient for multi-language writers.

Describe the solution you'd like
Support only a subset of them, which contains the most widely used languages. There is not so much work to do to only support the languages listed below, for example. I am not familiar with Java, or I will do it by myself.

Additional context

Language Geographic area Language tag (ll-CC)1 LCID
Arabic Saudi Arabia ar-SA 1025
Bulgarian Bulgaria bg-BG 1026
Chinese (Simplified) People's Republic of China zh-CN 2052
Chinese Taiwan zh-TW 1028
Croatian Croatia hr-HR 1050
Czech Czech Republic cs-CZ 1029
Danish Denmark da-DK 1030
Dutch Netherlands nl-NL 1043
English United States en-US 1033
Estonian Estonia et-EE 1061
Finnish Finland fi-FI 1035
French France fr-FR 1036
German Germany de-DE 1031
Greek Greece el-GR 1032
Hebrew Israel he-IL 1037
Hindi India hi-IN 1081
Hungarian Hungary hu-HU 1038
Indonesian Indonesia id-ID 1057
Italian Italy it-IT 1040
Japanese Japan ja-JP 1041
Kazakh Kazakhstan kk-KZ 1087
Korean Korea ko-KR 1042
Latvian Latvia lv-LV 1062
Lithuanian Lithuania lt-LT 1063
Malay Malaysia ms-MY 1086
Norwegian (Bokmål) Norway nb-NO 1044
Polish Poland pl-PL 1045
Portuguese Brazil pt-BR 1046
Portuguese Portugal pt-PT 2070
Romanian Romania ro-RO 1048
Russian Russia ru-RU 1049
Serbian (Latin) Serbia sr-latn-RS 2074
Slovak Slovakia sk-SK 1051
Slovenian Slovenia sl-SI 1060
Spanish Spain es-ES 3082
Swedish Sweden sv-SE 1053
Thai Thailand th-TH 1054
Turkish Türkiye tr-TR 1055
Ukrainian Ukraine uk-UA 1058
Vietnamese Vietnam vi-VN 1066
@Alexandra-Stath
Copy link
Contributor

Hello there,
I am a student in a technology field University and for my semester course I have been required to work on an Open Source Software project. Given that I have little experience in programming I would like to contribute to this issue, added under the good first issue tag.
Please assign me the issue.
Thank you in advance
Alexandra Stathopoulou

@ThiloteE ThiloteE moved this from Free to take to Reserved in Candidates for University Projects Mar 23, 2023
@ThiloteE ThiloteE moved this from Free to take to Reserved in Good First Issues Mar 23, 2023
@ThiloteE ThiloteE added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Mar 23, 2023
@github-actions
Copy link
Contributor

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

@yenniejunvu
Copy link
Contributor

Hi! I'm a university student and would like to attempt this. Is there any place I should start? I see that in MSBibMapping.java, it only supports English, which I assume is what we are aiming to change.

@Siedlerchr
Copy link
Member

Siedlerchr commented Mar 28, 2023

@yenniejunvu Are you working together with @Alexandra-Stath because she was first who wanted to solve this issue.
But codewise you would simply create a BiMap, with the biblatex language codes and the lcid mappings so it can be used for import as welll.

For the supported languages in biblatex: Section 2.2.2 (Field language and the table) https://ctan.joethei.xyz/macros/latex/contrib/biblatex/doc/biblatex.pdf

For MsOffice: https://learn.microsoft.com/en-us/openspecs/office_standards/ms-oe376/6c085406-a698-4e12-9d4d-c3b0ee3dbc4a

@yenniejunvu
Copy link
Contributor

Ah I see, thank you so much for the guidance and quick response! I see that the code would be implemented here:

public static int getLCID(String language) {
        // TODO: add language to LCID mapping
        // 0x0409 is American English
        return 0x0409;
    } 

And no, I am not working with the person above. Would it be possible to still submit a PR for this though?

@ThiloteE
Copy link
Member

In principle, yes you can submit a PR for this issue, even though it has been reserved for another student or group of students.
We at JabRef are happy this issue is of interest to multiple parties and of course would review all PRs, if there are any.
Collaboration will certainly improve and certify your teamwork skills.

Regardless, I am concerned, since both of you seem to be students. Students are special:

  • not all grading schemes take teamwork into account --> Might be harder for your lecturer to grade you.
  • Multiple people working on the same issue might produce multiple pull-requests. --> JabRef developers may not merge all of them, if they provide similar functionality --> Will this affect your grade?

For the above concerns, unless you explicitly can come to terms with these limitations and @Alexandra-Stath also agrees, I would advise to choose another issue. One that is not yet reserved.

@yenniejunvu
Copy link
Contributor

Whether my PR get merged or not has no effect on my grade, so no worries about that.

Also, I understand and will look for other good first issues if @Alexandra-Stath does not agree. Thanks for the help.

@Alexandra-Stath
Copy link
Contributor

Hello @yenniejunvu,
I have started working on the issue above for my semester course and our contribution is supposed to be some lines long to be acceptable. That's why I don't think we could work together on this subject. However, if the JabRef team doesn't have a problem reviewing both PRs then you can also work on the issue separately, if you cannot find another one suitable for you.
Alexandra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
export / save FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. microsoft office
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants