Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize scrollbars in the change resolver dialog #9576

Closed
HoussemNasri opened this issue Jan 21, 2023 · 8 comments · Fixed by #10587
Closed

Synchronize scrollbars in the change resolver dialog #9576

HoussemNasri opened this issue Jan 21, 2023 · 8 comments · Fixed by #10587
Assignees
Labels
collaboration FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty.
Milestone

Comments

@HoussemNasri
Copy link
Member

image

@DanielS01ss
Copy link

Hi!
I would love to work on this task

@HoussemNasri
Copy link
Member Author

This issue is kind of a follow-up to #9533, so there is nothing to do here until that pr is merged. But you can have a look at other goodfirstissues.

@HoussemNasri HoussemNasri added good first issue An issue intended for project-newcomers. Varies in difficulty. and removed status: stale labels Mar 22, 2023
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Mar 22, 2023
@HoussemNasri HoussemNasri added this to the v6.0 milestone Mar 22, 2023
@HoussemNasri HoussemNasri removed their assignment Mar 22, 2023
@karan-prajapati-976
Copy link

Hey
I would like to work on this task

@ThiloteE ThiloteE moved this from Free to take to Reserved in Good First Issues Mar 26, 2023
@HoussemNasri HoussemNasri moved this from Reserved to Free to take in Good First Issues Oct 5, 2023
@u7074786
Copy link
Contributor

Hi, I would like to work on this issue for a university assignment of mine, could I please be assigned to it?

I'm new to working on open source repos like this, so some suggestions on where to get started would also be appreciated.

@ThiloteE ThiloteE moved this from Free to take to Reserved in Good First Issues Oct 12, 2023
@ThiloteE ThiloteE added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Oct 12, 2023
@github-actions
Copy link
Contributor

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

@ThiloteE
Copy link
Member

ThiloteE commented Oct 12, 2023

@u7074786 this issue here is related to the backups feature, as you can see in the screenshot. Have a look at the docs: https://docs.jabref.org/advanced/autosave#where-can-i-find-the-backup-files. You can trigger the backup dialogue, if I am not mistaken, by

  1. creating a library (the .bib file) with entries
  2. then saving this library and closing JabRef
  3. modifying your .bib file outside JabRef with a text editor (e.g. changing the title of an entry)
  4. Starting JabRef and opening the library.

@HoussemNasri
Copy link
Member Author

HoussemNasri commented Oct 12, 2023

then saving this library and closing JabRef

You don't need to close JabRef at step 2. This way, it will trigger the change resolver dialog, which is used by the backup dialog to merge changes from backup.

I'm new to working on open-source repos like this, so some suggestions on where to get started would also be appreciated.

In addition, to what ThiloteE has already said, this is the class that you need to change. The idea is to synchronize the vertical scroll bar of the entry preview (and BibTeX source code preview) of the original entry and the modified entry. I also encourage you to read the JavaDoc of the ScrollPane class.

@koppor
Copy link
Member

koppor commented Oct 28, 2023

BibTeX source synch is still open (see #10587 (comment) for details)

@github-project-automation github-project-automation bot moved this from Reserved to Done in Good First Issues Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
collaboration FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants