Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add INSPIRE HEP Fetcher to "Update with bibliographic information from the web" #9351

Closed
Siedlerchr opened this issue Nov 4, 2022 · 8 comments · Fixed by #9602
Closed

Add INSPIRE HEP Fetcher to "Update with bibliographic information from the web" #9351

Siedlerchr opened this issue Nov 4, 2022 · 8 comments · Fixed by #9602
Assignees
Labels
fetcher good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@Siedlerchr
Copy link
Member

Is your suggestion for improvement related to a problem? Please describe.
https://discourse.jabref.org/t/add-inspirehep-as-resource-to-update-the-bibliographic-data/3612

However, it would be nice to add InspireHEP as one of the resources to fetch bibliographic data from, so these keys can also be fetched from InspireHEP for entries, which had been imported from elsewhere or are missing an citation key.

Describe the solution you'd like
Add the fetcher to the LIST

Additional context

grafik

Implementation details
The INSPIRE HEP Fetcher needs to implement EntryBasedFetcher interface and needs to be added to the set of getEntryBasedFetchers in WebFetcher.class

The fields doi or arxivid could be used as fields
https://github.com/inspirehep/rest-api-doc#external-identifiers

@Siedlerchr Siedlerchr added fetcher good first issue An issue intended for project-newcomers. Varies in difficulty. labels Nov 4, 2022
@Siedlerchr Siedlerchr moved this to Free to take in Good First Issues Nov 4, 2022
@sreenath-tm
Copy link
Contributor

I would like to contribute to the issue. Can you assign this to me.

@lak7
Copy link
Contributor

lak7 commented Jan 20, 2023

I would love to contribute to this issue. So can assign me for this.

@ThiloteE ThiloteE moved this from Free to take to Reserved in Good First Issues Jan 20, 2023
@lak7
Copy link
Contributor

lak7 commented Jan 21, 2023

I have implemented the InspireHepFetcher class, however, I am currently encountering errors and facing challenges in completing the code to retrieve the bibliographic entries. Could you please provide guidance on how to overcome these difficulties and successfully complete the implementation?
Screenshot_20230121_212239
Screenshot_20230121_212508
Screenshot_20230121_212531

@Siedlerchr
Copy link
Member Author

@lak7 Hi, thanks for your work! Best is to create a Pull Request early on so we can better see the context and can help

@lak7
Copy link
Contributor

lak7 commented Feb 3, 2023

Hi @Siedlerchr, just updating that I'm still working on this issue and I will create a pull request shortly.

@lak7
Copy link
Contributor

lak7 commented Feb 7, 2023

Hey @Siedlerchr, I have created a Pull Request. Can you review the PR and guide me further.

@ThiloteE ThiloteE moved this from Reserved to In Progress in Good First Issues Feb 7, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Good First Issues Feb 25, 2023
@github-project-automation github-project-automation bot moved this from Normal priority to Done in Features & Enhancements Feb 25, 2023
@lak7
Copy link
Contributor

lak7 commented Feb 25, 2023

@Siedlerchr,

I am writing to apologize for the delay in completing the assigned issue and not being able to address the feedback you provided in the pull request in a timely manner.

Unfortunately, I had to prioritize my college exams and was not able to devote the necessary time to the project during this period. While I realize that this caused inconvenience and delays for you and the team, I hope you can understand that my studies had to take priority at that time.

Thank you for your understanding and patience during this time. Please let me know if there is anything else I can do to help or if you have any further concerns.

@Siedlerchr
Copy link
Member Author

No problem, we all work at JabRef in our spare time and being a former student, I know the stressful exam phase.
I was just checking some open PRs and tried to reduce the number of open PRs. You did already a good foundation of work. And it was just a matter of implicating the code.
So all fine! But you are of course welcome to take any other issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fetcher good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants