Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac No more global menu #9247

Closed
Siedlerchr opened this issue Oct 12, 2022 · 9 comments
Closed

Mac No more global menu #9247

Siedlerchr opened this issue Oct 12, 2022 · 9 comments
Assignees
Labels
bug Confirmed bugs or reports that are very likely to be bugs
Milestone

Comments

@Siedlerchr
Copy link
Member

Regression from #9217

Executed ./gradllew run

grafik

@Siedlerchr Siedlerchr added the bug Confirmed bugs or reports that are very likely to be bugs label Oct 12, 2022
@Siedlerchr
Copy link
Member Author

Siedlerchr commented Oct 12, 2022

Binary from jabref works fine

@Siedlerchr Siedlerchr changed the title Java default icon instead of JabRef icon in Tray after cli fix Mac No more global menu Oct 17, 2022
@Siedlerchr
Copy link
Member Author

Siedlerchr commented Oct 17, 2022

A second thing with the launcher stuff now, the top menu is gone!
grafik

@Siedlerchr Siedlerchr added this to the v5.8 milestone Oct 17, 2022
@Siedlerchr
Copy link
Member Author

my gues is that the toolkit is initalized too late?

@tobiasdiez
Copy link
Member

I don't see where this is coming from, the structure of the code remained the same:

before: JabRefLauncher.main (entry class) calls JabRefMain.main (extending Application), which calls launch
after: Launcher.main (entry class) calls MainApplication.create (extending Application), which calls launch

So maybe it works if create is renamed to main?

@Siedlerchr
Copy link
Member Author

I tested it with the reverted PR and there it works fine. But I will try with the main. Maybe also something with the gradle main?

@Siedlerchr
Copy link
Member Author

One thing I noticed is that the arguments array is not passed to the launch method. Will test further

@koppor koppor mentioned this issue Oct 21, 2022
6 tasks
@koppor
Copy link
Member

koppor commented Oct 24, 2022

Should work - checking the notarized version is open.

@koppor koppor assigned Siedlerchr and unassigned tobiasdiez Oct 24, 2022
@Siedlerchr
Copy link
Member Author

JabRef 5.7-tags-testmacnotarization.200--2022-10-31--e7c8535
Mac OS X 11.7.1 x86_64
Java 18.0.2.1
JavaFX 19+11

Notarized version starts fine.

@tobiasdiez
Copy link
Member

Thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs
Projects
Archived in project
Development

No branches or pull requests

3 participants