Rank: a single click do not unset the field value

[mlep]

JabRef version

Latest development branch build (please note build date below)

Operating system

GNU / Linux

Details on version and operating system

JabRef 5.7--2022-08-04--da8586f Linux 4.19.0-21-amd64 amd64 Java 18.0.2 JavaFX 18.0.1+2

Checked with the latest development build

• I made a backup of my libraries before testing the latest development version.
• I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

In the rank column, the rank can be set from one to five stars using a single left-click. However, once set, it cannot be unset (i.e. going to zero stars) using the same single left-click. A double-click is needed, which is inconsistent with the UI behavior for other special fields.

1. Display the rank column (in Options -> Preferences -> Entry table)
2. For an entry, do a left click on the first star (the one to the left (this sets the rank: the star is not dim anymore)
3. Do another left click on this first star.
   • Expected behavior: this unsets the rank, dimming the star.
   • Observed behavior: nothing happens.

In fact, a double click on the rank column do the job, but this is inconsistent with the behavior of the other special fields (printed, relevance), where a single left-click unset the field.

Appendix

...

Log File

Paste an excerpt of your log file here

[koppor]

JabRef 3.8.2:

[sreenath-tm]

I'm interested in contributing to this issue, so before I start working it, would you mind sparing your time explaining what the fix will be like and pointing me to some resources to get started.

[ThiloteE]

Check out https://github.com/JabRef/jabref/blob/main/CONTRIBUTING.md for a start. Also, https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace is worth having a look at. Feel free to ask if you have any questions here on GitHub or also at JabRef's Gitter chat.

Try to open a (draft) pull request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

[Siedlerchr]

I think @0x002A already took a look at that issue and came up with something

[0x002A]

Sorry for the late reply.

I indeed tried to fix it. The problem I encountered is that I don’t have access to previous and the new count of stars at the same time and thus can’t implement special behaviour if the user clicks on the current count of stars.

I had no time so far to look further in this. Therefore, I am ok with someone else to look into this. Also, I can provide some hints where to look for the implementation if wished. Let me know.

[shafinkamal]

I can provide some hints where to look for the implementation if wished. Let me know.

Hi @0x002A, I'm a new contributor — could you please provide the hints/information as to where to look for the implementation of the stars?

Thanks

[YuiDOS]

Hi, I am a university CS student and I would like to work on this issue with my groupmate as my first contribution to open-source project. Since there is no one assigned for this issue, could you please assign this issue to me? Thank you.

[YuiDOS]

Hi community, since the issue is more complicated than I thought, I am unassigning myself.
For new assignee, please have a look at the pull request opened by me (also see comments in that PR), it may provide some useful idea to help you to start with.
Cheers.