Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing an UNC path into "Linked files" -> "Main file directory" should trigger validation at field exit #8107

Closed
2 tasks done
koppor opened this issue Sep 30, 2021 · 3 comments · Fixed by #8112
Closed
2 tasks done

Typing an UNC path into "Linked files" -> "Main file directory" should trigger validation at field exit #8107

koppor opened this issue Sep 30, 2021 · 3 comments · Fixed by #8112
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@koppor
Copy link
Member

koppor commented Sep 30, 2021

JabRef version

Latest development branch build (please note build date below)

Operating system

Windows

Details on version and operating system

Windows 10

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Open JabRef Preferences
  2. Navigate to "Linked files"
  3. Select box "Main file directory"
  4. Type \\w
  5. Error dialog appears
    image

Expected behavior: No error dialog. UNC path should be validated NOT during typing, but after leaving the text field

Appendix

No response
@Siedlerchr Siedlerchr added good first issue An issue intended for project-newcomers. Varies in difficulty. bug Confirmed bugs or reports that are very likely to be bugs labels Sep 30, 2021
@berry120
Copy link
Contributor

berry120 commented Oct 1, 2021

Happy to take a look at this 👍

@Siedlerchr
Copy link
Member

@berry120 Cool! For getting started check out the guide for setting up a workspace!
https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace
If you have any questions, feel free to ask here or in our gitter chat!

@berry120 berry120 mentioned this issue Oct 1, 2021
Merged
5 tasks
@berry120
Copy link
Contributor

berry120 commented Oct 1, 2021

@Siedlerchr Thanks! I've got everything running and submitted a PR, anything that needs doing differently please let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Bugs
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't throw exception when validating invalid paths
3 participants
@Siedlerchr @koppor @berry120