Dark theme: Search: case sensitive is case insensitive (and vice-versa)

[mlep]

JabRef 5.1--2020-08-25--2ce90ad
Linux 4.9.0-13-amd64 amd64
Java 15-ea

• Mandatory: I have tested the latest development version from http://builds.jabref.org/master/ and the problem persists

With the dark theme, if the "case sensitive" button is activated in the search bar, the search is case unsensitive.
And if the "case sensitive" button is deactivated in the search bar, the search is case sensitive.
Note: It works as expected in the light mode.

Steps to reproduce the behavior:

0. activate the light theme (and restart)
1. open https://github.com/JabRef/jabref/blob/master/src/test/resources/testbib/jabref-authors.bib
2. in the search bar, type "garrido"
3. if "case sensitive" is activated (i.e. "abc" is bold in the button), "No result found".
   if "case sensitive" is deactivated (i.e. "abc" is light in the button), "9 results found".
   (as expected)
4. now activate the dark theme (and restart)
5. in the search bar, type "garrido"
6. if "case sensitive" is activated (i.e. "abc" is bold in the button), "9 results found"
   
   if "case sensitive" is deactivated (i.e. "abc" is light in the button), "No result found"
   

So, in the dark theme:

1. the behavior is opposite to the one of the light theme
2. search is visually case sensitive when, in fact, it is not.

[mlep]

The same goes with the button for regular expression search: when supposedly activated (i.e. button in bold), search works like if the button is not activated. And vice-versa:

• title=modeling ==> "Found 7 results."
• title=modelling ==> "Found 5 results."
• title=modell?ing and regular expression button bold ==> "No result found."
• title=modell?ing and regular expression button dimmed ==> "Found 12 results."

[Siedlerchr]

Thanks for the investigation, seems like the the CSS colors/highlighing are wrong in the Dark.css
Maybe sth with the active/armed.
https://github.com/JabRef/jabref/blob/master/src/main/java/org/jabref/gui/Dark.css

[vatsal-M]

Our team @ISD14-LNMIIT wants to work on this issue. Please assign this issue to us!
@Siedlerchr @mlep

[vatsal-M]

We are a team of college undergrads and we have to solve an issue on Github as our project. We are following the team software process and as such it will take about 2 weeks for us to resolve the issue and we will ensure high-quality work. @Siedlerchr @mlep

[vatsal-M]

We (ISD14-LNMIIT) had been assigned a different issue on jabref but one of the team members got COVID-19 and we also had our mid-term exams because of which we didn't make a pull request and when we were about to make a pull request we saw that the issue has been closed. This is a very important project and we will ensure that this issue will be resolved as soon as possible. Please consider this team as it is very important for our grades. @Siedlerchr @mlep

[vatsal-M]

@Siedlerchr Can you assign @ISD14-LNMIIT this issue as I'm a part of this team?

[Siedlerchr]

I can only assign persons.

[vatsal-M]

@Siedlerchr Is there any acceptance test for the issue? if there is then could you tell us about that as we will run it and provide a quality solution

[Siedlerchr]

Just test it manually, create a PR, then we will review the code changes and merge if all is good.
See also our https://devdocs.jabref.org for getting started.

As I outlined earlier, the issue is probably a CSS issue in the Dark.css. The dark theme can be enabled in the preferences of JabRef.
The dark.css just overwrites some properties of the Base.css

[vatsal-M]

@Siedlerchr ok thank you!

[Siedlerchr]

For referenes:
The ToggleButton Style in the css applies to both the regex and the case sensitvy button, e.g. both are defined as ToggleButton
The properties of the toggle button:
https://openjfx.io/javadoc/14/javafx.graphics/javafx/scene/doc-files/cssref.html#togglebutton

[k3KAW8Pnf7mkmdSMPHz27]

I believe the classes are set to icon-button in

jabref/src/main/java/org/jabref/gui/icon/IconTheme.java

Lines 339 to 344 in 350ec1f

	public ToggleButton asToggleButton() {
	ToggleButton button = new ToggleButton();
	button.setGraphic(getGraphicNode());
	button.getStyleClass().add("icon-button");
	return button;
	}

[tobiasdiez]

Thanks to @kingmanas and his team, this should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

[mlep]

This is now working as expected. Thank you @kingmanas!