Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message when changing the theme #5509

Closed
tobiasdiez opened this issue Oct 24, 2019 · 4 comments
Closed

Improve message when changing the theme #5509

tobiasdiez opened this issue Oct 24, 2019 · 4 comments
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. preferences type: enhancement ui

Comments

@tobiasdiez
Copy link
Member

After changing the theme in the preferences (Preferences > Appearance), a message is displayed à la "Changed theme to: xyz", where "xyz" is "Base.css" or "Dark.css" depending on the new theme. These should be replaced by better names such as "Light theme" or "Dark theme".

Code implementation: Introduce enum for themes with the properties "display name" (localized), "name" (for storage in the preferences) and "css file name".

@tobiasdiez tobiasdiez added type: enhancement ui preferences good first issue An issue intended for project-newcomers. Varies in difficulty. labels Oct 24, 2019
@jairus-crabb
Copy link

Hello, I am a new GitHub user and would like to tackle this issue!

@namanvats
Copy link

I am working on it.

@carlg0ransson
Copy link
Contributor

Hey, I just created a pull request for this issue #5584

@tobiasdiez
Copy link
Member Author

Thanks to @carlg0ransson this is now implemented in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. preferences type: enhancement ui
Projects
None yet
Development

No branches or pull requests

4 participants