Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New entry not selected in entry table when entering data in field used for sorting #3373

Closed
tpet opened this issue Oct 30, 2017 · 16 comments
Closed
Labels
bug Confirmed bugs or reports that are very likely to be bugs maintable ui

Comments

@tpet
Copy link

tpet commented Oct 30, 2017

JabRef version: JabRef 4.0
Linux 4.4.8-040408-generic amd64
Java 1.8.0_151

Steps to reproduce:

  1. Create a new entry.
  2. Fill in fields, switch tabs in the entry editor.
  3. The entry is not selected in the entry table nor it is scrolled to to make it visible. I would expect displaying and selecting the new entry in the table just after its creation.

In previous versions, the entry was selected in the entry table (or at least shown, I'm not sure) after switching tabs within the entry editor, which was very handy, because otherwise shortcuts do not work for this new entry, but rather for some previously selected entry from the table. One for example cannot F4 to open a newly linked pdf without first finding and selecting the new entry in the table.

@AEgit
Copy link

AEgit commented Oct 30, 2017

This might be a duplicate of:
#3286

Might be related to this:
#3176

@Siedlerchr
Copy link
Member

Windows 10, can not reproduce this with the current master version:

grafik
Could you please check this with the master version from here?
http://builds.jabref.org/master/

@Siedlerchr Siedlerchr added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Dec 16, 2017
@tpet
Copy link
Author

tpet commented Dec 16, 2017

It first selects the entry when I add it.
But it deselects the entry once I start typing into a field which is used as sorting key.

@Siedlerchr
Copy link
Member

@tpet Okay, now I can confirm the behavior. It only is deselected when the field is used for sorting.

@Siedlerchr Siedlerchr changed the title New entry not selected in entry table New entry not selected in entry table when entering data in field used for sorting Dec 16, 2017
@Siedlerchr Siedlerchr added bug Confirmed bugs or reports that are very likely to be bugs and removed type: enhancement status: waiting-for-feedback The submitter or other users need to provide more information about the issue labels Dec 16, 2017
@tpet
Copy link
Author

tpet commented Dec 17, 2017

Actually, the sorting factor is a new thing. Originally, the entry was not selected at all.

@tobiasdiez
Copy link
Member

This should be fixed in the latest development version. Could you please check the build from https://builds.jabref.org/maintable-beta/. Thanks! Note this version is in a very early beta stage and might not work as expected. See #3621 for further details.

@tpet
Copy link
Author

tpet commented Jan 30, 2018

I would like to test it but unfortunately using JabRef--maintable-beta--latest.jar I am not even able to open a single bib file.
I run the thing: java -jar /tmp/JabRef--maintable-beta--latest.jar -d all -b
Using menu, I open database at /tmp/tmp.bib with 3 entries.
In console, I can see (the last message):
23:18:55.794 [AWT-EventQueue-0] INFO org.jabref.logic.importer.OpenDatabase - Opening: /tmp/tmp.bib
In the GUI status bar I can see: Status: Opened library '/tmp/tmp.bib' with 3 entries.
But the entry table is not shown at all and the whole GUI is frozen.

(Actually I had several other issues with both v4.0 and v4.1 so I had to switch back to v3.8.2, which works fine for me. Versions 4.* are crashing, auto file links do not work, menu and status bar is cropped etc.)

@tobiasdiez
Copy link
Member

Thanks for the follow-up and trying out the new version. I'll try to reproduce the freezing issue and fix it. @Siedlerchr for you it worked with Linux but it took some time, right?

@tobiasdiez
Copy link
Member

@tpet These issues should now be fixed in the most recent build from https://builds.jabref.org/maintable-beta/.

@tpet
Copy link
Author

tpet commented Feb 21, 2018

Now, it does not even open, no GUI is shown.
Running java -jar /tmp/JabRef--maintable-beta--latest.jar -d all -b
I get Setting all preferences to default values.
in console but no window appears.

@Siedlerchr
Copy link
Member

Could you check your Java version and openjfx version (if you don't use oracle Java) otherwise make sure to have the latest Java 8 version.

Sometimes it also happens that the Found a backup of your database dialog opens up hiding the window.

@AEgit
Copy link

AEgit commented Feb 21, 2018

As far as I can tell, the bug is not fixed in:

JabRef 4.2-dev--snapshot--2018-02-21--maintable-beta--58cfd7f48
Windows 10 10.0 amd64 
Java 1.8.0_161

When following the three steps given by @tpet the new entry is not shown in the main table. The entry preview of the newly created entry, however, is shown after closing the entry editor. When editing an entry, it is deselected (i. e., not marked in blue anymore) but still shown in the main table. I'm not completely sure, whether such a behaviour addresses all of the issues mentioned in the bug report (?).

Some bugs I noticed:

  1. When trying to save the newly created entry, JabRef requires suddently massive CPU power and appears to freeze. It is necessary to close the program and reopen it, to continue working. The newly created entry, however, still appears to be part of the database (despite the fact, that the database could not be saved properly).
  2. The search feature is definitely much slower for large databases than in:
JabRef 4.2-dev--snapshot--2018-02-15--master--36e4f0e56
Windows 10 10.0 amd64 
Java 1.8.0_161

I had already reported this before (#1513 (comment)) but was not completely sure at the time, because I had not used the master version of JabRef 4.2 for a while (I'm still using 3.8.2 for my actual work just because it is rock solid and has a high performance also for large databases). This time I tried both JabRef 4.2-dev--snapshot--2018-02-15--master--36e4f0e56 and JabRef 4.2-dev--snapshot--2018-02-21--maintable-beta--58cfd7f48 one after another. The maintable-beta branch is definitely slower than the master branch. Maybe this is related to the fact that the maintable-beta branch search appears to suggest keywords when starting the search, while the master branch search does not, as far as I can tell.

@tobiasdiez tobiasdiez reopened this Feb 21, 2018
@tpet
Copy link
Author

tpet commented Feb 21, 2018

I have Java:

$ java -version
java version "1.8.0_161"
Java(TM) SE Runtime Environment (build 1.8.0_161-b12)
Java HotSpot(TM) 64-Bit Server VM (build 25.161-b12, mixed mode)

Not sure about openjfx, how can I check that?

@Siedlerchr
Copy link
Member

@tpet cat $JAVA_HOME/jre/lib/javafx.properties
I don't know which Linux system you are using, but for many you could also check your package manager for the package openjfx

@tpet
Copy link
Author

tpet commented Feb 22, 2018

Version of javafx:

$ cat $JAVA_HOME/jre/lib/javafx.properties
javafx.runtime.version=8.0.161
javafx.runtime.build=b12

@Siedlerchr
Copy link
Member

Thank you for reporting this issue. We think, that is already fixed in our development version and consequently the change will be included in the next release.

We would like to ask you to use a development build from https://builds.jabref.org/master and report back if it works for you. Please remember to make a backup of your library before trying-out this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs maintable ui
Projects
None yet
Development

No branches or pull requests

4 participants