Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Add Group Dialog #2630

Closed
Siedlerchr opened this issue Mar 10, 2017 · 14 comments
Closed

New Add Group Dialog #2630

Siedlerchr opened this issue Mar 10, 2017 · 14 comments

Comments

@Siedlerchr
Copy link
Member

Siedlerchr commented Mar 10, 2017

Idea for a new javafx styled Group Dialog:
@tobiasdiez WDYT?
(My first try with the scence builder)

CreateGroups.fxml.txt

grafik

@tobiasdiez
Copy link
Member

tobiasdiez commented Mar 11, 2017

Looks definitely better than the old dialog, good job.

  • I would move "Group definition" to the top. For edit, I would even compress it into a drop-down and for "Add group" make it a wizard 2-step process where on the first page the user decides upon the type of group (and there is some description what each type can do) and the second page is the normal edit dialog. What do you think about this idea?
  • "General" is not really necessary / doesn't really provide additional information. I'm also not sure if we should really separate the options into groups "General" and "Type-specific". Maybe just have a list of options and a bigger space after the "general options"?
  • If you use text = "%Color" then the text should be translated automatically (maybe it wasn't % as modifier...just have a look at the other dialogs)

Thanks that you attack this "Baustelle" 😄

@Siedlerchr
Copy link
Member Author

Found a nice idea for a Wizard like thing:
http://www.guigarage.com/2014/05/datafx-tutorial-3/

@Siedlerchr
Copy link
Member Author

I have now separated the dialog in two parts

grafik

grafik

@tobiasdiez
Copy link
Member

I like it! Maybe still move the "Options" to the second page...not sure through. @JabRef/developers what you do you think?

In my opinion the icon and color can be put on the same line (with the icon first).

@Siedlerchr
Copy link
Member Author

Regarding Icon I had the idea to integrate an ImageView component with a File Chooser, so that user direclty can open the icon/image from their file system

@tobiasdiez
Copy link
Member

Right now the icon only allows a string (the identifier in the materialdesigns font) and not a path. Thus it is probably preferable to show a list of (predefined) icons instead of a file chooser.

@Siedlerchr
Copy link
Member Author

Yes, I will take this into account and maybe probide a list with images/icons to browse from

@Siedlerchr
Copy link
Member Author

So, my current idea is to use an auto complete text box (and I hope it will work) for searching the icons like it is possible on the website
http://fontawesome.io/icons/
grafik

@matthiasgeiger
Copy link
Member

Is this Icon stuff really worth the effort?

I would also prefer to have only a single dialog with the ability to switch from one type to another during creation of a group...

@Siedlerchr
Copy link
Member Author

@matthiasgeiger That icon stuff is just some nice to have stuff.
My idea is that when you add a group this wizard is shown and when you right click on the group -> Edit defintion (name etcs ) and switch group type. Which then just would select the right dialog page of the wizard - with the ability to go back/forward to the other page.

In my opinion this is useful as I sometimes just want to edit the name of a group or the type.

@tobiasdiez
Copy link
Member

As soon as the new javafx dialog is ready, the swing compatibility workaround introduced in https://github.com/JabRef/jabref/pull/2727/files#diff-6c6d2c1a2528d4dc593f3844f5c680d2R129 should be removed again.

@Clarke92
Copy link

Hi guys, is this one still available? I would love to fix some issues for you!

@Siedlerchr
Copy link
Member Author

@Clarke92 Hey, thanks for the interesting in contributing! Yes, you can surely take my PR where I added the fxml files as a starting point: #2643

To get started, have a look at our Contributing guide.

@tobiasdiez tobiasdiez removed the good first issue An issue intended for project-newcomers. Varies in difficulty. label Apr 25, 2018
@Siedlerchr Siedlerchr added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Aug 12, 2018
@tobiasdiez tobiasdiez removed the good first issue An issue intended for project-newcomers. Varies in difficulty. label Sep 15, 2018
@tobiasdiez
Copy link
Member

Since this dialog is now converted to JavaFX, there is no real urge to redesign it (PRs in this direction are of course welcome).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants