Web search preferences "Custom API key" table modifications not discarded

[LoayGhreeb]

When making changes to the "Custom API key" table in the Web search tab of the preferences, the changes are always saved even when I click Cancel.

Steps to Reproduce:

1. Open JabRef Preferences.
2. Navigate to the Web Search tab.
3. Make any modifications in the Custom API key table.
4. Click Cancel to close the Preferences window.
5. Reopen the Preferences and navigate back to the Web Search tab.
6. Observe that the modifications are still present.

Expected Behavior:
Clicking Cancel should discard any changes made to the Custom API Key table.

Actual Behavior:
Changes to the Custom API Key table are saved.

[u7663394]

Hi,

I have read through this issue and was wondering if I can be assigned to this issue. I am asking to be assigned due to a university group project.

Thank you.

[github-actions]

Welcome to the vibrant world of open-source development with JabRef!

Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

[u7663394]

Hello,

I have just resolved this issue and have created a PR (#11977).

More details can be referred to the PR above.

Thank you.

[u7663394]

Additionally, when I was modifying the code, I noticed some red-highlighted errors in the PreferencesDialogView class. Since this is unrelated to the issue, I did not make any changes, but I believe it is worth reporting.

[koppor]

Additionally, when I was modifying the code, I noticed some red-highlighted errors in the PreferencesDialogView class. Since this is unrelated to the issue, I did not make any changes, but I believe it is worth reporting.

Here, it is green. It also compiles on the CI.

Could you hover on the import for KeyCode?`What is the error message?

Did you follow the steps to enable compilation by IntelliJ?

[u7663394]

Additionally, when I was modifying the code, I noticed some red-highlighted errors in the PreferencesDialogView class. Since this is unrelated to the issue, I did not make any changes, but I believe it is worth reporting.

Here, it is green. It also compiles on the CI.

Could you hover on the import for KeyCode?`What is the error message?

Did you follow the steps to enable compilation by IntelliJ?

That's a bit strange; I confirmed that I followed the steps to enable IntelliJ's compilation. It shows "cannot resolve symbol KeyCode".

[koppor]

Let's check MainTable.java - the other symbols of javafx.scene.input are found?`

[u7663394]

Let's check MainTable.java - the other symbols of javafx.scene.input are found?`

It shows like this - all other symbols can be found, but KeyCode

[LoayGhreeb]

Can you try "Rescan Project Indexes"

[u7663394]

Yeah, I have tried. After clicking 'Rescan Project Indexes' and 'Reopen Project', the problem still exists.

But it does not affect me to build or run JabRef normally, which I don't know why.

The CI are all passed, too.

[koppor]

What if you press on the "Refresh" button on Gradle?

---

If these kind of things happen once, they might be happen on other sides. This could be an FAQ, therefore, we ask for possible fixes etc.

[u7663394]

What if you press on the "Refresh" button on Gradle?

If these kind of things happen once, they might be happen on other sides. This could be an FAQ, therefore, we ask for possible fixes etc.

Hi, I just tried to refresh, but it does not worked.
Btw, I am on Windows 11 x64 system and using Intellij IDEA 2022.3.3 version.

[koppor]

Hi, I just tried to refresh, but it does not worked. Btw, I am on Windows 11 x64 system and using Intellij IDEA 2022.3.3 version.

Your IntelliJ is pretty old. I am on 2024.2.3. Then it might be an issue of that version and we don't need to invest time. In case you are going to contribute more to the project and cannot update to 2024, we could invest time.

[u7663394]

Understood, thank you for your response. I can upgrade IntelliJ IDEA, and this issue does not currently affect my normal operation with JabRef. Cheers :)