Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming a file should re-add the extension if missing #11903

Closed
Siedlerchr opened this issue Oct 9, 2024 · 2 comments · Fixed by #11908
Closed

Renaming a file should re-add the extension if missing #11903

Siedlerchr opened this issue Oct 9, 2024 · 2 comments · Fixed by #11908
Assignees
Labels
entry-editor external files FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. ui

Comments

@Siedlerchr
Copy link
Member

Is your suggestion for improvement related to a problem? Please describe.
When I rename a file, the extension is not kept

Describe the solution you'd like

  1. I add a file to an entry. I want to rename the file For that, I press Ctrl+R
  2. The rename dialog appears - the whole filename is selected:
    image
  3. I can type a new file name (e.g., demo
  4. I press Enter
  • Expected result: The file is named demo.pdf
  • Actual result: The file is named demo (without extension)

JabRef should check whether the user removed the extension. If JabRef cannot find a new extension, it should put the old one (and not just keep the file as is)

Other implementation possibility: The dialog should select the filename only - without extension.

@Siedlerchr Siedlerchr added good first issue An issue intended for project-newcomers. Varies in difficulty. ui external files entry-editor labels Oct 9, 2024
@ivobubenko
Copy link
Contributor

Hi, I would like to work on this issue, please assign it to me.

@Siedlerchr Siedlerchr added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Welcome to the vibrant world of open-source development with JabRef!

Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
entry-editor external files FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. ui
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants