Remove listeners in RedoAction for memory efficiency

[subhramit]

Context: PR #11758
Based on the TODO comment:

jabref/src/main/java/org/jabref/gui/undo/RedoAction.java

Lines 24 to 28 in 8412e65

	// TODO: The old listener should be removed. Otherwise, memory consumption will increase.
	stateManager.activeTabProperty().addListener((observable, oldValue, activeLibraryTab) -> {
	activeLibraryTab.ifPresent(libraryTab ->
	this.executable.bind(libraryTab.getUndoManager().getRedoableProperty()));
	});

Refs. #11758 (comment)

[subhramit]

Some hints:

• Remove the listeners based on activeLibraryTab.
• Alternatively, WeakChangeLIsteners can also be used.

[melisolmez]

Hi, can ı work on this issue ?

[subhramit]

Hi, can ı work on this issue ?

Sure.

[github-actions]

Welcome to the vibrant world of open-source development with JabRef!

Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

[ThiloteE]

@subhramit when assigning somebody, you also have to manually change the issue from "free to take" to "reserved" in the project. I tried to automate this, but GitHub Projects isn't capable of doing so, the last time I checked.

[subhramit]

@subhramit when assigning somebody, you also have to manually change the issue from "free to take" to "reserved" in the project. I tried to automate this, but GitHub Projects isn't capable of doing so, the last time I checked.

Hey, I tried to change it, but I think only maintainers can do that.

[melisolmez]

Hello @subhramit, while I solve this isue I noticed this error:

Can we solve this problem with an if statement that checks for null in the RedoAction.excecute method?

[subhramit]

Can we solve this problem with an if statement that checks for null in the RedoAction.excecute method?

Did this error exist before? (if yes, then could you elaborate the steps to reproduce it?)

Else, if this was triggered after your changes, submit a PR so that we can review and make suggestions.

[melisolmez]

Can we solve this problem with an if statement that checks for null in the RedoAction.excecute method?

Did this error exist before? (if yes, then could you elaborate the steps to reproduce it?)

Else, if this was triggered after your changes, submit a PR so that we can review and make suggestions.

yes this exist before, not beacufe of my changed. If you want you are try on your local.

[subhramit]

yes this exist before, not beacufe of my changed. If you want you are try on your local.

Yes, please write down the steps to reproduce the exception. It is also okay if you want to open another issue regarding it for more visibility, and then solve both the issues together.

[melisolmez]

yes this exist before, not beacufe of my changed. If you want you are try on your local.

Yes, please write down the steps to reproduce the exception. It is also okay if you want to open another issue regarding it for more visibility, and then solve both the issues together.

When I run jabref, the redo and undo buttons become active. When you press them directly without doing anything, this error occurs.
I can solve with this issue.

[Siedlerchr]

The buttons should be disabled if no library is opened that is probably the issue here

[melisolmez]

The buttons should be disabled if no library is opened that is probably the issue here

Yes but there are not disabled. If you want,You can open an issue about this error

[koppor]

The buttons should be disabled if no library is opened that is probably the issue here
Yes but there are not disabled. If you want,You can open an issue about this error

Do you refer to #463? Does this issue need to be reopened? If yes, please refine the issue. Make a screenshot and point out which actions should be disabled.