Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cleanup operation for journal abbreviation #11791

Open
tobiasdiez opened this issue Sep 19, 2024 · 5 comments
Open

Add cleanup operation for journal abbreviation #11791

tobiasdiez opened this issue Sep 19, 2024 · 5 comments
Assignees
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) cleanup-ops type: enhancement

Comments

@tobiasdiez
Copy link
Member

Is your suggestion for improvement related to a problem? Please describe.
Users usually have a convention to always use abbreviated or unabbreviated journal titles. JabRef should help them enforce this convention using a cleanup operation.

Describe the solution you'd like
Add option to abbreviate/expand the journal title in the Cleanup operation dialog.

@tina9452
Copy link

hi, I’m interested in this. Could you please assign this to me? Thank you so much~

@koppor
Copy link
Member

koppor commented Oct 19, 2024

Refinement of this issue:

  1. Remove the actions of the Quality menu:

Image

  1. Add the actions to the "Cleanup entries" dialog:

Image

Add a new heading "Journal-realted" with a button group

  • Abbreviate (default)
  • Abbreviate (dotless)
  • Abbreviate (shortest unique)
  • Unabbreviate
  • No changes

Have No changes as default.

Store the setting in the preferences so that after re-opening of the dialog, the same settings are stored.

One needs to move org.jabref.gui.journals.UndoableAbbreviator#abbreviate to separate clean up jobs. Implement interface org.jabref.logic.cleanup.CleanupJob. Four jobs need to be introduced.

@koppor
Copy link
Member

koppor commented Oct 19, 2024

The refactoring of org.jabref.gui.journals.UndoableAbbreviator#abbreviate has to be done first (in a separate PR), because this refactoring is also needed at #11305.

@koppor
Copy link
Member

koppor commented Oct 19, 2024

/assign @tina9452

Copy link
Contributor

👋 Hey @tina9452, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

⏳ Please note, you will be automatically unassigned if the issue isn't closed within 30 days (by 18 November 2024). A maintainer can also add the "📌 Pinned"" label to prevent automatic unassignment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) cleanup-ops type: enhancement
Projects
None yet
Development

No branches or pull requests

3 participants