Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use tab to jump to next field in some single-line fields #11785

Closed
2 tasks done
tobiasdiez opened this issue Sep 18, 2024 · 5 comments · Fixed by #11886
Closed
2 tasks done

Cannot use tab to jump to next field in some single-line fields #11785

tobiasdiez opened this issue Sep 18, 2024 · 5 comments · Fixed by #11886
Assignees
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@tobiasdiez
Copy link
Member

JabRef version

5.15 (latest release)

Operating system

Windows

Details on version and operating system

No response

Checked with the latest development build (copy version output from About dialog)

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Go into the URL field in the entry editor
  2. Press Tab.

Empty space is inserted instead of jumping to the next field.

Appendix

The reason is that https://github.com/JabRef/jabref/blob/main/src/main/java/org/jabref/gui/fieldeditors/EditorTextArea.java is used over https://github.com/JabRef/jabref/blob/main/src/main/java/org/jabref/gui/fieldeditors/EditorTextField.java in some fields that sholud be normal single-line fields: Url, Identifier, Owner, Issn

@tobiasdiez tobiasdiez added bug Confirmed bugs or reports that are very likely to be bugs entry-editor good first issue An issue intended for project-newcomers. Varies in difficulty. labels Sep 18, 2024
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Sep 18, 2024
@ryan-carpenter
Copy link

in some fields that sholud be normal single-line fields: Url, Identifier, Owner, Issn

It is not uncommon for applications not to allow use of Tab key to insert a Tab character, even with multi-line text. I think it would be suitable for Tab to behave the same (move to next field) in single-line and multi-line fields. Alternatively, consider adding default or custom shortcuts to for moving forward and backward through the fields.

Note that <Shift + Tab> moves backward, regardless of the current field type but forward navigation using is interrupted by the multi-line fields.

@tobiasdiez
Copy link
Member Author

The only real multi-line fields would be comment and abstract, right? These are usually on their own tab, so it's not important to have Tab as a navigation between fields in this case.

@ryan-carpenter
Copy link

The only real multi-line fields would be comment and abstract, right?

Good point, but remember that standard fields can be configured as multi-line in preferences and that non-standard fields can be added and configured as multi-line.

@juliusalberto
Copy link
Contributor

Hi, I would like to work on this issue. Can I be assigned to this issue? Thanks!

@ThiloteE ThiloteE moved this from Free to take to Assigned in Candidates for University Projects Oct 2, 2024
@ThiloteE ThiloteE moved this from Free to take to Assigned in Good First Issues Oct 2, 2024
@ThiloteE ThiloteE added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Welcome to the vibrant world of open-source development with JabRef!

Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants