Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compare button to duplicates in Citation relations tab #11192

Closed
AbdAlRahmanGad opened this issue Apr 14, 2024 · 5 comments · Fixed by #11915
Closed

Add compare button to duplicates in Citation relations tab #11192

AbdAlRahmanGad opened this issue Apr 14, 2024 · 5 comments · Fixed by #11915
Assignees
Labels
FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. ui

Comments

@AbdAlRahmanGad
Copy link
Contributor

AbdAlRahmanGad commented Apr 14, 2024

I think it would be nice if we added a compare button to the duplicates in the citation relations tab.
The compare button will open the "Possible duplicate entries" window.

It will look something like this:
Screenshot 2024-04-14 at 10 51 47 AM

For more context:
The duplication detection in the citation relations tab was implemented in this PR #11186

@koppor
Copy link
Member

koppor commented Apr 15, 2024

@AbdAlRahmanGad Nice idea! Helps to see if JabRef works right - and also helps to add missing data to JabRef (if available)

@koppor koppor added ui good first issue An issue intended for project-newcomers. Varies in difficulty. labels Apr 15, 2024
@harshithap2000
Copy link

@koppor I wish to work on this issue with a teammate for university assignment.

I had a query, I see that gui/entryeditor/citationrelationtab/CitationRelationsTab.java (shown below) has the code for rendering the citation list. Where can I find the UI files for the same? So that I can add a compare button along with the link button.

.map(localEntry -> new CitationRelationItem(entr, localEntry, true)) // duplicate entry
.orElseGet(() -> new CitationRelationItem(entr, false)))
                

@ThiloteE ThiloteE added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Jun 13, 2024
Copy link
Contributor

Welcome to the vibrant world of open-source development with JabRef!

Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

@Siedlerchr
Copy link
Member

The UI is direclty construced in CitationRelationsTab getPaneAndStartSearch

@KumaLuo
Copy link
Contributor

KumaLuo commented Oct 9, 2024

Hi @HoussemNasri @Siedlerchr @koppor, is this issue still available to take? Could you please assign this issue to me?
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. ui
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants