Import by id: cancel doesn't really cancel the request

[tobiasdiez]

JabRef version

5.10 (latest release)

Operating system

Windows

Details on version and operating system

No response

Checked with the latest development build (copy version output from About dialog)

• I made a backup of my libraries before testing the latest development version.
• I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

Import something by id, and click "cancel". The dialog disappears, so it looks like it canceled the request. But if the request actually times out (or fails for some other reason) you still get the error dialog shown.

A proper fix would require to cancel/disconnect from the actual http request, and that might be a major refactoring. But at least the composite id fetcher should have a option to not ask the next id fetcher, and errors should be hidden from the users after cancel.

Appendix

...

Log File

Paste an excerpt of your log file here

[SUPWEZZ]

Hi @tobiasdiez, I would like the work on the issue, please assign it to me if possible!

[ThiloteE]

Is this a good first issue for somebody that is new to coding Tobias?
If not, @SUPWEZZ, please check out our good first issues collected at our projects board.

[SUPWEZZ]

Hi @ThiloteE , I've noticed the issue titled "Unchecked 'Do not ask again' does not work," and I'm very interested in attempting to resolve it. If it's not already assigned, may I take a stab at addressing this problem?

Thank you for your consideration.

[ThiloteE]

Well, if you insist and you are confident, then have a go at it.

[github-actions]

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

[koppor]

@ThiloteE I think, @SUPWEZZ meant koppor#566. They is already assigned there. Thus, I unassign here.