Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to enable journal information fetcher #10458

Closed
2 tasks done
tobiasdiez opened this issue Oct 7, 2023 · 3 comments · Fixed by #10598
Closed
2 tasks done

Make it easier to enable journal information fetcher #10458

tobiasdiez opened this issue Oct 7, 2023 · 3 comments · Fixed by #10598
Assignees
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor

Comments

@tobiasdiez
Copy link
Member

JabRef version

Latest development branch build (please note build date below)

Operating system

Windows

Details on version and operating system

No response

Checked with the latest development build (copy version output from About dialog)

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

In the entry editor, click the small "i" next to the journal name. It complains that one should enable the journal information fetching in the preferences.

Two bugs/inconveniences:

  • It says the option is under "Web search", but it is actually under "Entry editor".
  • Secondly, it should just ask the user directly whether he wants to enable it or not. It's pretty inconvenient to manually open the preferences to set the correct toggle. I feel like we talked about this in the implementation PR, but for me it doesn't make much sense to point the user to the preferences if the feature is disabled.

if (preferences.shouldEnableJournalPopup() == EntryEditorPreferences.JournalPopupEnabled.DISABLED) {
dialogService.notify(
Localization.lang("Please enable journal information fetching in %0 > %1",
Localization.lang("Preferences"),
Localization.lang("Web search"))
);
return false;
}

Appendix

...

Log File
Paste an excerpt of your log file here
@tobiasdiez tobiasdiez added bug Confirmed bugs or reports that are very likely to be bugs entry-editor labels Oct 7, 2023
@Zhouheng98
Copy link
Contributor

Hi, I am a student, can I try to solve this problem?

@tobiasdiez
Copy link
Member Author

Sure, go ahead!

@ThiloteE
Copy link
Member

@calixtus since this is preferences related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants