l10n and minor code tweak

JabRef · Nov 2, 2023 · 452bb51 · 452bb51
1 parent 648f293
commit 452bb51
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/src/main/java/org/jabref/gui/fieldeditors/JournalInfoOptInDialogHelper.java b/src/main/java/org/jabref/gui/fieldeditors/JournalInfoOptInDialogHelper.java
@@ -21,12 +21,12 @@ public static boolean isJournalInfoEnabled(DialogService dialogService, EntryEdi
                             Localization.lang("Preferences"),
                             Localization.lang("Entry editor"))
             );
-            if (enableJournalPopup) {
-                preferences.setEnableJournalPopup(EntryEditorPreferences.JournalPopupEnabled.ENABLED);
-                return true;
-            } else {
-                return false;
-            }
+
+            preferences.setEnableJournalPopup(enableJournalPopup
+                    ? EntryEditorPreferences.JournalPopupEnabled.ENABLED
+                    : EntryEditorPreferences.JournalPopupEnabled.DISABLED);
+
+            return enableJournalPopup;
         }
 
         boolean journalInfoEnabled = dialogService.showConfirmationDialogAndWait(

diff --git a/src/main/resources/l10n/JabRef_en.properties b/src/main/resources/l10n/JabRef_en.properties
@@ -477,7 +477,6 @@ Year=Year
 ISSN\ or\ journal\ name\ required\ for\ fetching\ journal\ information=ISSN or journal name required for fetching journal information
 Fetch\ journal\ information\ online\ to\ show=Fetch journal information online to show
 Allow\ sending\ ISSN\ to\ a\ JabRef\ online\ service\ (SCimago)\ for\ fetching\ journal\ information=Allow sending ISSN to a JabRef online service (SCimago) for fetching journal information
-Please\ enable\ journal\ information\ fetching\ in\ %0\ >\ %1=Please enable journal information fetching in %0 > %1
 Categories=Categories
 ISSN=ISSN
 Publisher=Publisher