Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traffic Signs date filters #228

Closed
ireun opened this issue Dec 26, 2023 · 0 comments
Closed

Traffic Signs date filters #228

ireun opened this issue Dec 26, 2023 · 0 comments
Assignees

Comments

@ireun
Copy link
Contributor

ireun commented Dec 26, 2023

Hello there!

First of all Thank You for maintaining this plugin! <3

Now I'd like to share my feedback (and maybe some tips for other users)

  1. Did what you suggested in Add Filter for Mapillary Traffic Sign layer #227 - I probably wouldn't have found the mapillary-traffic-signs-source layer myself
  2. I converted this layer to OSM data to poke around
  3. This layer, on it's own seems to have no icons in it?
  4. After adding normal Mapillary Traffic Signs layer and disabling it the Icons are now visible.
  5. Indeed these points have epoch timestamps in them
  6. So I can do a normal JOSM filter with something like last_seen_at > 1672531200000 and it shows me all signs found in 2023! Great!
  7. Unfortunately "Mapillary Filter" date dialog sets a wrong filter!
    image
    It doesn't use the timestamp but a date! This filter shows nothing.
  8. Again manually setting the filter to last_seen_at > 1672531200000 works.
    image

So I think point no. 7 should be fixed?

@tsmock tsmock self-assigned this Dec 26, 2023
@tsmock tsmock closed this as completed in eb79054 Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants