Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation and implementation of runoff_file and alt_runoff #66

Open
thurber opened this issue Apr 29, 2022 · 2 comments
Open

Documentation and implementation of runoff_file and alt_runoff #66

thurber opened this issue Apr 29, 2022 · 2 comments

Comments

@thurber
Copy link

thurber commented Apr 29, 2022

Hello,

A postdoc user of Xanthos pointed out this issue to me. They were trying to reproduce the example run but with user-provided PET and RUNOFF files, but a few things conspire to prevent this:

  1. The documentation here describes a runoff_file setting under the [Runoff] configuration tag. As far as I can see in the code, this setting is totally ignored. Instead, one needs to use the [Routing] [[mrtm]] alt_runoff setting.

  2. Even so, if pet_module = none and runoff_module = none, neither the pet_file nor the alt_runoff file get passed on to the routing module (or the result files).

I will submit a Pull Request that can fix this issue for this particular use case, but I'm not as familiar with the broader context of the model so you may wish to address in a different way!

@thurber
Copy link
Author

thurber commented Apr 29, 2022

#67 is a potential fix for this

@yvettelkxii
Copy link

thank you for your contribution,but still I can't get the program to read my own runoff data. Could you teach me more about it? My email is [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants