Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test failing when ruby is built against libedit instead of readline #247

Open
boutil opened this issue Feb 11, 2021 · 3 comments
Open

test failing when ruby is built against libedit instead of readline #247

boutil opened this issue Feb 11, 2021 · 3 comments

Comments

@boutil
Copy link

boutil commented Feb 11, 2021

Hi,

Recently, Debian started to build the ruby interpreter against libedit instead of readline for license reasons:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=977724
One test in highline gem started to fail after this change:

  1) Failure:
TestHighLine#test_readline_mode [/tmp/autopkgtest-lxc.ln2dsy6w/downtmp/build.OjD/src/test/test_highline.rb:391]:
Expected /Prompt:\ \ any\ input\n/ to match "Prompt:  ".

170 runs, 1089 assertions, 1 failures, 0 errors, 3 skips

(see e.g.: https://ci.debian.net/data/autopkgtest/testing/amd64/r/ruby-highline/10349342/log.gz)

This does not seem to have an influence on other packages in Debian depending on this library though.

@abinoam
Copy link
Collaborator

abinoam commented Feb 15, 2021

Thanks for reporting.
I can't make any promise when I could see this.
I welcome any PR to fix it.

@abinoam
Copy link
Collaborator

abinoam commented Feb 15, 2021

Perhaps it's time for us to search again for a pure ruby readline implementation.

@kbrock
Copy link
Contributor

kbrock commented Aug 7, 2023

irb uses https://github.com/ruby/reline
Would something like that meet the needs?

Sorry I haven't had the chance to test it out not drop it into here.

Per some reline PRs, it looks like in ruby 3.3, readline will be aliases to reline. And there are some possibly issues with configuration (at the current time).

So moving across and ensuring compatibility before the switch may be a good thing.
Or the problem may just go away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants