-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathfabpot.json
5236 lines (5222 loc) · 292 KB
/
fabpot.json
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
[
{
"id": "2497563625",
"type": "IssueCommentEvent",
"actor": {
"id": 47313,
"login": "fabpot",
"gravatar_id": "",
"url": "https://api.github.com/users/fabpot",
"avatar_url": "https://avatars.githubusercontent.com/u/47313?"
},
"repo": {
"id": 458058,
"name": "symfony/symfony",
"url": "https://api.github.com/repos/symfony/symfony"
},
"payload": {
"action": "created",
"issue": {
"url": "https://api.github.com/repos/symfony/symfony/issues/13071",
"labels_url": "https://api.github.com/repos/symfony/symfony/issues/13071/labels{/name}",
"comments_url": "https://api.github.com/repos/symfony/symfony/issues/13071/comments",
"events_url": "https://api.github.com/repos/symfony/symfony/issues/13071/events",
"html_url": "https://github.com/symfony/symfony/pull/13071",
"id": 52609817,
"number": 13071,
"title": "[Console] added possibility to choose right answers for a ConfirmationQuestion",
"user": {
"login": "AlexDpy",
"id": 7074618,
"avatar_url": "https://avatars.githubusercontent.com/u/7074618?v=3",
"gravatar_id": "",
"url": "https://api.github.com/users/AlexDpy",
"html_url": "https://github.com/AlexDpy",
"followers_url": "https://api.github.com/users/AlexDpy/followers",
"following_url": "https://api.github.com/users/AlexDpy/following{/other_user}",
"gists_url": "https://api.github.com/users/AlexDpy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/AlexDpy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AlexDpy/subscriptions",
"organizations_url": "https://api.github.com/users/AlexDpy/orgs",
"repos_url": "https://api.github.com/users/AlexDpy/repos",
"events_url": "https://api.github.com/users/AlexDpy/events{/privacy}",
"received_events_url": "https://api.github.com/users/AlexDpy/received_events",
"type": "User",
"site_admin": false
},
"labels": [
{
"url": "https://api.github.com/repos/symfony/symfony/labels/Console",
"name": "Console",
"color": "DDDDDD"
}
],
"state": "open",
"locked": false,
"assignee": null,
"milestone": null,
"comments": 2,
"created_at": "2014-12-21T23:32:59Z",
"updated_at": "2015-01-07T08:39:00Z",
"closed_at": null,
"pull_request": {
"url": "https://api.github.com/repos/symfony/symfony/pulls/13071",
"html_url": "https://github.com/symfony/symfony/pull/13071",
"diff_url": "https://github.com/symfony/symfony/pull/13071.diff",
"patch_url": "https://github.com/symfony/symfony/pull/13071.patch"
},
"body": "| Q | A\r\n| ------------- | ---\r\n| Bug fix? | no\r\n| New feature? | yes\r\n| BC breaks? | no\r\n| Deprecations? | no\r\n| Tests pass? | yes\r\n| Fixed tickets | \r\n| License | MIT\r\n| Doc PR | \r\n\r\nWith this pull request, the ConfirmationQuestion can accept one (or many) answer(s) like 'o', 'oui' (in french) or 'si' (in spanish) or anything else, it's up to you !\r\nDefault value is still 'y' (yes)"
},
"comment": {
"url": "https://api.github.com/repos/symfony/symfony/issues/comments/68992715",
"html_url": "https://github.com/symfony/symfony/pull/13071#issuecomment-68992715",
"issue_url": "https://api.github.com/repos/symfony/symfony/issues/13071",
"id": 68992715,
"user": {
"login": "fabpot",
"id": 47313,
"avatar_url": "https://avatars.githubusercontent.com/u/47313?v=3",
"gravatar_id": "",
"url": "https://api.github.com/users/fabpot",
"html_url": "https://github.com/fabpot",
"followers_url": "https://api.github.com/users/fabpot/followers",
"following_url": "https://api.github.com/users/fabpot/following{/other_user}",
"gists_url": "https://api.github.com/users/fabpot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fabpot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fabpot/subscriptions",
"organizations_url": "https://api.github.com/users/fabpot/orgs",
"repos_url": "https://api.github.com/users/fabpot/repos",
"events_url": "https://api.github.com/users/fabpot/events{/privacy}",
"received_events_url": "https://api.github.com/users/fabpot/received_events",
"type": "User",
"site_admin": false
},
"created_at": "2015-01-07T08:39:00Z",
"updated_at": "2015-01-07T08:39:00Z",
"body": "Looks like a duplicate of #11129 (@WouterJ)"
}
},
"public": true,
"created_at": "2015-01-07T08:39:01Z",
"org": {
"id": 143937,
"login": "symfony",
"gravatar_id": "",
"url": "https://api.github.com/orgs/symfony",
"avatar_url": "https://avatars.githubusercontent.com/u/143937?"
}
},
{
"id": "2497549134",
"type": "IssueCommentEvent",
"actor": {
"id": 47313,
"login": "fabpot",
"gravatar_id": "",
"url": "https://api.github.com/users/fabpot",
"avatar_url": "https://avatars.githubusercontent.com/u/47313?"
},
"repo": {
"id": 458058,
"name": "symfony/symfony",
"url": "https://api.github.com/repos/symfony/symfony"
},
"payload": {
"action": "created",
"issue": {
"url": "https://api.github.com/repos/symfony/symfony/issues/13297",
"labels_url": "https://api.github.com/repos/symfony/symfony/issues/13297/labels{/name}",
"comments_url": "https://api.github.com/repos/symfony/symfony/issues/13297/comments",
"events_url": "https://api.github.com/repos/symfony/symfony/issues/13297/events",
"html_url": "https://github.com/symfony/symfony/pull/13297",
"id": 53574280,
"number": 13297,
"title": "[Process] Fix input reset in WindowsPipes",
"user": {
"login": "mpajunen",
"id": 7025066,
"avatar_url": "https://avatars.githubusercontent.com/u/7025066?v=3",
"gravatar_id": "",
"url": "https://api.github.com/users/mpajunen",
"html_url": "https://github.com/mpajunen",
"followers_url": "https://api.github.com/users/mpajunen/followers",
"following_url": "https://api.github.com/users/mpajunen/following{/other_user}",
"gists_url": "https://api.github.com/users/mpajunen/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mpajunen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mpajunen/subscriptions",
"organizations_url": "https://api.github.com/users/mpajunen/orgs",
"repos_url": "https://api.github.com/users/mpajunen/repos",
"events_url": "https://api.github.com/users/mpajunen/events{/privacy}",
"received_events_url": "https://api.github.com/users/mpajunen/received_events",
"type": "User",
"site_admin": false
},
"labels": [
],
"state": "open",
"locked": false,
"assignee": null,
"milestone": null,
"comments": 1,
"created_at": "2015-01-06T22:53:44Z",
"updated_at": "2015-01-07T08:27:37Z",
"closed_at": null,
"pull_request": {
"url": "https://api.github.com/repos/symfony/symfony/pulls/13297",
"html_url": "https://github.com/symfony/symfony/pull/13297",
"diff_url": "https://github.com/symfony/symfony/pull/13297.diff",
"patch_url": "https://github.com/symfony/symfony/pull/13297.patch"
},
"body": "| Q | A\r\n| ------------- | ---\r\n| Bug fix? | yes\r\n| New feature? | no\r\n| BC breaks? | no\r\n| Deprecations? | no\r\n| Tests pass? | yes\r\n| Fixed tickets | N/A\r\n| License | MIT\r\n| Doc PR | N/A\r\n\r\nUnsetting the input property causes an E_NOTICE error when the\r\nproperty is checked on line 249 (and is likely unintentional anyway)."
},
"comment": {
"url": "https://api.github.com/repos/symfony/symfony/issues/comments/68991769",
"html_url": "https://github.com/symfony/symfony/pull/13297#issuecomment-68991769",
"issue_url": "https://api.github.com/repos/symfony/symfony/issues/13297",
"id": 68991769,
"user": {
"login": "fabpot",
"id": 47313,
"avatar_url": "https://avatars.githubusercontent.com/u/47313?v=3",
"gravatar_id": "",
"url": "https://api.github.com/users/fabpot",
"html_url": "https://github.com/fabpot",
"followers_url": "https://api.github.com/users/fabpot/followers",
"following_url": "https://api.github.com/users/fabpot/following{/other_user}",
"gists_url": "https://api.github.com/users/fabpot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fabpot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fabpot/subscriptions",
"organizations_url": "https://api.github.com/users/fabpot/orgs",
"repos_url": "https://api.github.com/users/fabpot/repos",
"events_url": "https://api.github.com/users/fabpot/events{/privacy}",
"received_events_url": "https://api.github.com/users/fabpot/received_events",
"type": "User",
"site_admin": false
},
"created_at": "2015-01-07T08:27:37Z",
"updated_at": "2015-01-07T08:27:37Z",
"body": "Looks good to me. :+1: \r\n\r\nping @romainneutron "
}
},
"public": true,
"created_at": "2015-01-07T08:27:38Z",
"org": {
"id": 143937,
"login": "symfony",
"gravatar_id": "",
"url": "https://api.github.com/orgs/symfony",
"avatar_url": "https://avatars.githubusercontent.com/u/143937?"
}
},
{
"id": "2497532378",
"type": "IssuesEvent",
"actor": {
"id": 47313,
"login": "fabpot",
"gravatar_id": "",
"url": "https://api.github.com/users/fabpot",
"avatar_url": "https://avatars.githubusercontent.com/u/47313?"
},
"repo": {
"id": 458058,
"name": "symfony/symfony",
"url": "https://api.github.com/repos/symfony/symfony"
},
"payload": {
"action": "closed",
"issue": {
"url": "https://api.github.com/repos/symfony/symfony/issues/13283",
"labels_url": "https://api.github.com/repos/symfony/symfony/issues/13283/labels{/name}",
"comments_url": "https://api.github.com/repos/symfony/symfony/issues/13283/comments",
"events_url": "https://api.github.com/repos/symfony/symfony/issues/13283/events",
"html_url": "https://github.com/symfony/symfony/issues/13283",
"id": 53518335,
"number": 13283,
"title": "[Security] Remove old session data on auth strategy migrate",
"user": {
"login": "xelaris",
"id": 2466932,
"avatar_url": "https://avatars.githubusercontent.com/u/2466932?v=3",
"gravatar_id": "",
"url": "https://api.github.com/users/xelaris",
"html_url": "https://github.com/xelaris",
"followers_url": "https://api.github.com/users/xelaris/followers",
"following_url": "https://api.github.com/users/xelaris/following{/other_user}",
"gists_url": "https://api.github.com/users/xelaris/gists{/gist_id}",
"starred_url": "https://api.github.com/users/xelaris/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/xelaris/subscriptions",
"organizations_url": "https://api.github.com/users/xelaris/orgs",
"repos_url": "https://api.github.com/users/xelaris/repos",
"events_url": "https://api.github.com/users/xelaris/events{/privacy}",
"received_events_url": "https://api.github.com/users/xelaris/received_events",
"type": "User",
"site_admin": false
},
"labels": [
],
"state": "closed",
"locked": false,
"assignee": null,
"milestone": null,
"comments": 0,
"created_at": "2015-01-06T14:15:07Z",
"updated_at": "2015-01-07T08:13:38Z",
"closed_at": "2015-01-07T08:13:38Z",
"body": "The original issue was #13026 and PR #13048 was a straight forward solution. This does not work for PHP <= 5.4.11 as stated by @derrabus in #13269. After reverting the PR in #13282, the original issue still exists. \r\n\r\nI see the following options:\r\n* Call `$request->getSession()->migrate(true)` (https://github.com/symfony/symfony/blob/2.3/src/Symfony/Component/Security/Http/Session/SessionAuthenticationStrategy.php#L50) only with `true`, if PHP is >5.4.11 (see PR #13286)\r\n* Add a new strategy to make it configurable if the session is migrated with session_regenerate_id(false) or session_regenerate_id(true)\r\n* Find a workaround\r\n\r\nLike @derrabus I'm in favor of using `true` depending on the PHP version.\r\n\r\nWhat are your opinions?"
}
},
"public": true,
"created_at": "2015-01-07T08:13:39Z",
"org": {
"id": 143937,
"login": "symfony",
"gravatar_id": "",
"url": "https://api.github.com/orgs/symfony",
"avatar_url": "https://avatars.githubusercontent.com/u/143937?"
}
},
{
"id": "2497532315",
"type": "IssuesEvent",
"actor": {
"id": 47313,
"login": "fabpot",
"gravatar_id": "",
"url": "https://api.github.com/users/fabpot",
"avatar_url": "https://avatars.githubusercontent.com/u/47313?"
},
"repo": {
"id": 458058,
"name": "symfony/symfony",
"url": "https://api.github.com/repos/symfony/symfony"
},
"payload": {
"action": "closed",
"issue": {
"url": "https://api.github.com/repos/symfony/symfony/issues/13269",
"labels_url": "https://api.github.com/repos/symfony/symfony/issues/13269/labels{/name}",
"comments_url": "https://api.github.com/repos/symfony/symfony/issues/13269/comments",
"events_url": "https://api.github.com/repos/symfony/symfony/issues/13269/events",
"html_url": "https://github.com/symfony/symfony/issues/13269",
"id": 53414230,
"number": 13269,
"title": "[Security] login_check route throws exception on php 5.4.4: Parent session handler is not open",
"user": {
"login": "derrabus",
"id": 1506493,
"avatar_url": "https://avatars.githubusercontent.com/u/1506493?v=3",
"gravatar_id": "",
"url": "https://api.github.com/users/derrabus",
"html_url": "https://github.com/derrabus",
"followers_url": "https://api.github.com/users/derrabus/followers",
"following_url": "https://api.github.com/users/derrabus/following{/other_user}",
"gists_url": "https://api.github.com/users/derrabus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/derrabus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/derrabus/subscriptions",
"organizations_url": "https://api.github.com/users/derrabus/orgs",
"repos_url": "https://api.github.com/users/derrabus/repos",
"events_url": "https://api.github.com/users/derrabus/events{/privacy}",
"received_events_url": "https://api.github.com/users/derrabus/received_events",
"type": "User",
"site_admin": false
},
"labels": [
],
"state": "closed",
"locked": false,
"assignee": null,
"milestone": null,
"comments": 14,
"created_at": "2015-01-05T16:31:58Z",
"updated_at": "2015-01-07T08:13:35Z",
"closed_at": "2015-01-07T08:13:35Z",
"body": "I tried to upgrade my client's Symfony application from 2.5.8 to the lastest 2.6-dev snapshot (12d8261). Unfortunately, the upgrade broke their login process completely, which worked fine with 2.6.1 and below.\r\n\r\nI could reproduce the problem by creating a new Symfony Standard application and implementing a login form as described [in the cookbook](http://symfony.com/doc/current/cookbook/security/form_login_setup.html). If I enter correct credentials in the form here, I get the following exception on the login_check route.\r\n\r\n```\r\n[1] Symfony\\Component\\Debug\\Exception\\ContextErrorException: Warning: SessionHandler::write(): Parent session handler is not open\r\n at n/a\r\n in /home/develop/projects/session-test/app/cache/dev/classes.php line 4606\r\n\r\n at Symfony\\Component\\Debug\\ErrorHandler->handleError('2', 'SessionHandler::write(): Parent session handler is not open', '/home/develop/projects/session-test/app/cache/dev/classes.php', '4606', array('sessionId' => 'vq1u2n2d008k0mbmc2hi0j0v55', 'data' => '_sf2_attributes|a:1:{s:17:\"_security_default\";s:853:\"C:74:\"Symfony\\Component\\Security\\Core\\Authentication\\Token\\UsernamePasswordToken\":765:{a:3:{i:0;N;i:1;s:7:\"default\";i:2;s:722:\"a:4:{i:0;O:41:\"Symfony\\Component\\Security\\Core\\User\\User\":7:{s:51:\"Symfony\\Component\\Security\\Core\\User\\Userusername\";s:4:\"demo\";s:51:\"Symfony\\Component\\Security\\Core\\User\\Userpassword\";s:4:\"demo\";s:50:\"Symfony\\Component\\Security\\Core\\User\\Userenabled\";b:1;s:60:\"Symfony\\Component\\Security\\Core\\User\\UseraccountNonExpired\";b:1;s:64:\"Symfony\\Component\\Security\\Core\\User\\UsercredentialsNonExpired\";b:1;s:59:\"Symfony\\Component\\Security\\Core\\User\\UseraccountNonLocked\";b:1;s:48:\"Symfony\\Component\\Security\\Core\\User\\Userroles\";a:1:{i:0;s:9:\"ROLE_USER\";}}i:1;b:1;i:2;a:1:{i:0;O:41:\"Symfony\\Component\\Security\\Core\\Role\\Role\":1:{s:47:\"Symfony\\Component\\Security\\Core\\Role\\Rolerole\";s:9:\"ROLE_USER\";}}i:3;a:0:{}}\";}}\";}_sf2_flashes|a:0:{}_sf2_meta|a:3:{s:1:\"u\";i:1420472792;s:1:\"c\";i:1420472792;s:1:\"l\";s:1:\"0\";}'))\r\n in line \r\n\r\n at SessionHandler->write('vq1u2n2d008k0mbmc2hi0j0v55', '_sf2_attributes|a:1:{s:17:\"_security_default\";s:853:\"C:74:\"Symfony\\Component\\Security\\Core\\Authentication\\Token\\UsernamePasswordToken\":765:{a:3:{i:0;N;i:1;s:7:\"default\";i:2;s:722:\"a:4:{i:0;O:41:\"Symfony\\Component\\Security\\Core\\User\\User\":7:{s:51:\"Symfony\\Component\\Security\\Core\\User\\Userusername\";s:4:\"demo\";s:51:\"Symfony\\Component\\Security\\Core\\User\\Userpassword\";s:4:\"demo\";s:50:\"Symfony\\Component\\Security\\Core\\User\\Userenabled\";b:1;s:60:\"Symfony\\Component\\Security\\Core\\User\\UseraccountNonExpired\";b:1;s:64:\"Symfony\\Component\\Security\\Core\\User\\UsercredentialsNonExpired\";b:1;s:59:\"Symfony\\Component\\Security\\Core\\User\\UseraccountNonLocked\";b:1;s:48:\"Symfony\\Component\\Security\\Core\\User\\Userroles\";a:1:{i:0;s:9:\"ROLE_USER\";}}i:1;b:1;i:2;a:1:{i:0;O:41:\"Symfony\\Component\\Security\\Core\\Role\\Role\":1:{s:47:\"Symfony\\Component\\Security\\Core\\Role\\Rolerole\";s:9:\"ROLE_USER\";}}i:3;a:0:{}}\";}}\";}_sf2_flashes|a:0:{}_sf2_meta|a:3:{s:1:\"u\";i:1420472792;s:1:\"c\";i:1420472792;s:1:\"l\";s:1:\"0\";}')\r\n in /home/develop/projects/session-test/app/cache/dev/classes.php line 4606\r\n\r\n at Symfony\\Component\\HttpFoundation\\Session\\Storage\\Proxy\\SessionHandlerProxy->write('vq1u2n2d008k0mbmc2hi0j0v55', '_sf2_attributes|a:1:{s:17:\"_security_default\";s:853:\"C:74:\"Symfony\\Component\\Security\\Core\\Authentication\\Token\\UsernamePasswordToken\":765:{a:3:{i:0;N;i:1;s:7:\"default\";i:2;s:722:\"a:4:{i:0;O:41:\"Symfony\\Component\\Security\\Core\\User\\User\":7:{s:51:\"Symfony\\Component\\Security\\Core\\User\\Userusername\";s:4:\"demo\";s:51:\"Symfony\\Component\\Security\\Core\\User\\Userpassword\";s:4:\"demo\";s:50:\"Symfony\\Component\\Security\\Core\\User\\Userenabled\";b:1;s:60:\"Symfony\\Component\\Security\\Core\\User\\UseraccountNonExpired\";b:1;s:64:\"Symfony\\Component\\Security\\Core\\User\\UsercredentialsNonExpired\";b:1;s:59:\"Symfony\\Component\\Security\\Core\\User\\UseraccountNonLocked\";b:1;s:48:\"Symfony\\Component\\Security\\Core\\User\\Userroles\";a:1:{i:0;s:9:\"ROLE_USER\";}}i:1;b:1;i:2;a:1:{i:0;O:41:\"Symfony\\Component\\Security\\Core\\Role\\Role\":1:{s:47:\"Symfony\\Component\\Security\\Core\\Role\\Rolerole\";s:9:\"ROLE_USER\";}}i:3;a:0:{}}\";}}\";}_sf2_flashes|a:0:{}_sf2_meta|a:3:{s:1:\"u\";i:1420472792;s:1:\"c\";i:1420472792;s:1:\"l\";s:1:\"0\";}')\r\n in line \r\n\r\n at session_write_close()\r\n in /home/develop/projects/session-test/app/cache/dev/classes.php line 4386\r\n\r\n at Symfony\\Component\\HttpFoundation\\Session\\Storage\\NativeSessionStorage->save()\r\n in /home/develop/projects/session-test/app/cache/dev/classes.php line 4214\r\n\r\n at Symfony\\Component\\HttpFoundation\\Session\\Session->save()\r\n in /home/develop/projects/session-test/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/EventListener/SaveSessionListener.php line 55\r\n\r\n at Symfony\\Component\\HttpKernel\\EventListener\\SaveSessionListener->onKernelResponse(object(FilterResponseEvent), 'kernel.response', object(ContainerAwareEventDispatcher))\r\n in line \r\n\r\n at call_user_func(array(object(SaveSessionListener), 'onKernelResponse'), object(FilterResponseEvent), 'kernel.response', object(ContainerAwareEventDispatcher))\r\n in /home/develop/projects/session-test/vendor/symfony/symfony/src/Symfony/Component/EventDispatcher/Debug/WrappedListener.php line 59\r\n\r\n at Symfony\\Component\\EventDispatcher\\Debug\\WrappedListener->__invoke(object(FilterResponseEvent), 'kernel.response', object(ContainerAwareEventDispatcher))\r\n in line \r\n\r\n at call_user_func(object(WrappedListener), object(FilterResponseEvent), 'kernel.response', object(ContainerAwareEventDispatcher))\r\n in /home/develop/projects/session-test/app/cache/dev/classes.php line 3876\r\n\r\n at Symfony\\Component\\EventDispatcher\\EventDispatcher->doDispatch(array(object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener)), 'kernel.response', object(FilterResponseEvent))\r\n in /home/develop/projects/session-test/app/cache/dev/classes.php line 3809\r\n\r\n at Symfony\\Component\\EventDispatcher\\EventDispatcher->dispatch('kernel.response', object(FilterResponseEvent))\r\n in /home/develop/projects/session-test/app/cache/dev/classes.php line 3970\r\n\r\n at Symfony\\Component\\EventDispatcher\\ContainerAwareEventDispatcher->dispatch('kernel.response', object(FilterResponseEvent))\r\n in /home/develop/projects/session-test/vendor/symfony/symfony/src/Symfony/Component/EventDispatcher/Debug/TraceableEventDispatcher.php line 112\r\n\r\n at Symfony\\Component\\EventDispatcher\\Debug\\TraceableEventDispatcher->dispatch('kernel.response', object(FilterResponseEvent))\r\n in /home/develop/projects/session-test/app/bootstrap.php.cache line 3040\r\n\r\n at Symfony\\Component\\HttpKernel\\HttpKernel->filterResponse(object(RedirectResponse), object(Request), '1')\r\n in /home/develop/projects/session-test/app/bootstrap.php.cache line 3011\r\n\r\n at Symfony\\Component\\HttpKernel\\HttpKernel->handleRaw(object(Request), '1')\r\n in /home/develop/projects/session-test/app/bootstrap.php.cache line 2982\r\n\r\n at Symfony\\Component\\HttpKernel\\HttpKernel->handle(object(Request), '1', true)\r\n in /home/develop/projects/session-test/app/bootstrap.php.cache line 3131\r\n\r\n at Symfony\\Component\\HttpKernel\\DependencyInjection\\ContainerAwareHttpKernel->handle(object(Request), '1', true)\r\n in /home/develop/projects/session-test/app/bootstrap.php.cache line 2376\r\n\r\n at Symfony\\Component\\HttpKernel\\Kernel->handle(object(Request))\r\n in /home/develop/projects/session-test/web/app_dev.php line 18\r\n```\r\n\r\nThis problem only appears on our old virtual machine running php 5.4.4. On my dev machine running Ubuntu 14.10 with the bundled php 5.5.12, everything works as expected. So, this issue is probably related to that old php version. Maybe, we're facing a similar issue here as in #5868 (just guessing)?\r\n\r\nMy client is aware, that this php version is fairly old, but the application has several hundred installations and most of them under that old php version, so the migration to a more recent php release will take some time. Untill then, I would need a fix or a workaround."
}
},
"public": true,
"created_at": "2015-01-07T08:13:35Z",
"org": {
"id": 143937,
"login": "symfony",
"gravatar_id": "",
"url": "https://api.github.com/orgs/symfony",
"avatar_url": "https://avatars.githubusercontent.com/u/143937?"
}
},
{
"id": "2497532259",
"type": "PullRequestEvent",
"actor": {
"id": 47313,
"login": "fabpot",
"gravatar_id": "",
"url": "https://api.github.com/users/fabpot",
"avatar_url": "https://avatars.githubusercontent.com/u/47313?"
},
"repo": {
"id": 458058,
"name": "symfony/symfony",
"url": "https://api.github.com/repos/symfony/symfony"
},
"payload": {
"action": "closed",
"number": 13286,
"pull_request": {
"url": "https://api.github.com/repos/symfony/symfony/pulls/13286",
"id": 26891802,
"html_url": "https://github.com/symfony/symfony/pull/13286",
"diff_url": "https://github.com/symfony/symfony/pull/13286.diff",
"patch_url": "https://github.com/symfony/symfony/pull/13286.patch",
"issue_url": "https://api.github.com/repos/symfony/symfony/issues/13286",
"number": 13286,
"state": "closed",
"locked": false,
"title": "[Security] Don't destroy the session on buggy php releases.",
"user": {
"login": "derrabus",
"id": 1506493,
"avatar_url": "https://avatars.githubusercontent.com/u/1506493?v=3",
"gravatar_id": "",
"url": "https://api.github.com/users/derrabus",
"html_url": "https://github.com/derrabus",
"followers_url": "https://api.github.com/users/derrabus/followers",
"following_url": "https://api.github.com/users/derrabus/following{/other_user}",
"gists_url": "https://api.github.com/users/derrabus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/derrabus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/derrabus/subscriptions",
"organizations_url": "https://api.github.com/users/derrabus/orgs",
"repos_url": "https://api.github.com/users/derrabus/repos",
"events_url": "https://api.github.com/users/derrabus/events{/privacy}",
"received_events_url": "https://api.github.com/users/derrabus/received_events",
"type": "User",
"site_admin": false
},
"body": "| Q | A\r\n| ------------- | ---\r\n| Bug fix? | yes\r\n| New feature? | no\r\n| BC breaks? | no\r\n| Deprecations? | no\r\n| Tests pass? | yes\r\n| Fixed tickets | #13269, #13283\r\n| License | MIT\r\n| Doc PR | none\r\n\r\nSee #13269 for the discussion. This workaround avoids destroying the old session after login on the migrate strategy when running under a php version that we know to be broken.\r\n\r\nCorresponding php bug: https://bugs.php.net/bug.php?id=63379",
"created_at": "2015-01-06T14:31:46Z",
"updated_at": "2015-01-07T08:13:32Z",
"closed_at": "2015-01-07T08:13:32Z",
"merged_at": null,
"merge_commit_sha": "b27e90c9372c3157f78649350d8001487b959921",
"assignee": null,
"milestone": null,
"commits_url": "https://api.github.com/repos/symfony/symfony/pulls/13286/commits",
"review_comments_url": "https://api.github.com/repos/symfony/symfony/pulls/13286/comments",
"review_comment_url": "https://api.github.com/repos/symfony/symfony/pulls/comments/{number}",
"comments_url": "https://api.github.com/repos/symfony/symfony/issues/13286/comments",
"statuses_url": "https://api.github.com/repos/symfony/symfony/statuses/83aaaa98c080610c9a5b4f29ad7f22dfef3ec3e6",
"head": {
"label": "derrabus:2.3-13269",
"ref": "2.3-13269",
"sha": "83aaaa98c080610c9a5b4f29ad7f22dfef3ec3e6",
"user": {
"login": "derrabus",
"id": 1506493,
"avatar_url": "https://avatars.githubusercontent.com/u/1506493?v=3",
"gravatar_id": "",
"url": "https://api.github.com/users/derrabus",
"html_url": "https://github.com/derrabus",
"followers_url": "https://api.github.com/users/derrabus/followers",
"following_url": "https://api.github.com/users/derrabus/following{/other_user}",
"gists_url": "https://api.github.com/users/derrabus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/derrabus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/derrabus/subscriptions",
"organizations_url": "https://api.github.com/users/derrabus/orgs",
"repos_url": "https://api.github.com/users/derrabus/repos",
"events_url": "https://api.github.com/users/derrabus/events{/privacy}",
"received_events_url": "https://api.github.com/users/derrabus/received_events",
"type": "User",
"site_admin": false
},
"repo": {
"id": 16010475,
"name": "symfony",
"full_name": "derrabus/symfony",
"owner": {
"login": "derrabus",
"id": 1506493,
"avatar_url": "https://avatars.githubusercontent.com/u/1506493?v=3",
"gravatar_id": "",
"url": "https://api.github.com/users/derrabus",
"html_url": "https://github.com/derrabus",
"followers_url": "https://api.github.com/users/derrabus/followers",
"following_url": "https://api.github.com/users/derrabus/following{/other_user}",
"gists_url": "https://api.github.com/users/derrabus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/derrabus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/derrabus/subscriptions",
"organizations_url": "https://api.github.com/users/derrabus/orgs",
"repos_url": "https://api.github.com/users/derrabus/repos",
"events_url": "https://api.github.com/users/derrabus/events{/privacy}",
"received_events_url": "https://api.github.com/users/derrabus/received_events",
"type": "User",
"site_admin": false
},
"private": false,
"html_url": "https://github.com/derrabus/symfony",
"description": "The Symfony PHP framework",
"fork": true,
"url": "https://api.github.com/repos/derrabus/symfony",
"forks_url": "https://api.github.com/repos/derrabus/symfony/forks",
"keys_url": "https://api.github.com/repos/derrabus/symfony/keys{/key_id}",
"collaborators_url": "https://api.github.com/repos/derrabus/symfony/collaborators{/collaborator}",
"teams_url": "https://api.github.com/repos/derrabus/symfony/teams",
"hooks_url": "https://api.github.com/repos/derrabus/symfony/hooks",
"issue_events_url": "https://api.github.com/repos/derrabus/symfony/issues/events{/number}",
"events_url": "https://api.github.com/repos/derrabus/symfony/events",
"assignees_url": "https://api.github.com/repos/derrabus/symfony/assignees{/user}",
"branches_url": "https://api.github.com/repos/derrabus/symfony/branches{/branch}",
"tags_url": "https://api.github.com/repos/derrabus/symfony/tags",
"blobs_url": "https://api.github.com/repos/derrabus/symfony/git/blobs{/sha}",
"git_tags_url": "https://api.github.com/repos/derrabus/symfony/git/tags{/sha}",
"git_refs_url": "https://api.github.com/repos/derrabus/symfony/git/refs{/sha}",
"trees_url": "https://api.github.com/repos/derrabus/symfony/git/trees{/sha}",
"statuses_url": "https://api.github.com/repos/derrabus/symfony/statuses/{sha}",
"languages_url": "https://api.github.com/repos/derrabus/symfony/languages",
"stargazers_url": "https://api.github.com/repos/derrabus/symfony/stargazers",
"contributors_url": "https://api.github.com/repos/derrabus/symfony/contributors",
"subscribers_url": "https://api.github.com/repos/derrabus/symfony/subscribers",
"subscription_url": "https://api.github.com/repos/derrabus/symfony/subscription",
"commits_url": "https://api.github.com/repos/derrabus/symfony/commits{/sha}",
"git_commits_url": "https://api.github.com/repos/derrabus/symfony/git/commits{/sha}",
"comments_url": "https://api.github.com/repos/derrabus/symfony/comments{/number}",
"issue_comment_url": "https://api.github.com/repos/derrabus/symfony/issues/comments/{number}",
"contents_url": "https://api.github.com/repos/derrabus/symfony/contents/{+path}",
"compare_url": "https://api.github.com/repos/derrabus/symfony/compare/{base}...{head}",
"merges_url": "https://api.github.com/repos/derrabus/symfony/merges",
"archive_url": "https://api.github.com/repos/derrabus/symfony/{archive_format}{/ref}",
"downloads_url": "https://api.github.com/repos/derrabus/symfony/downloads",
"issues_url": "https://api.github.com/repos/derrabus/symfony/issues{/number}",
"pulls_url": "https://api.github.com/repos/derrabus/symfony/pulls{/number}",
"milestones_url": "https://api.github.com/repos/derrabus/symfony/milestones{/number}",
"notifications_url": "https://api.github.com/repos/derrabus/symfony/notifications{?since,all,participating}",
"labels_url": "https://api.github.com/repos/derrabus/symfony/labels{/name}",
"releases_url": "https://api.github.com/repos/derrabus/symfony/releases{/id}",
"created_at": "2014-01-17T20:10:54Z",
"updated_at": "2015-01-02T10:13:49Z",
"pushed_at": "2015-01-07T08:04:46Z",
"git_url": "git://github.com/derrabus/symfony.git",
"ssh_url": "[email protected]:derrabus/symfony.git",
"clone_url": "https://github.com/derrabus/symfony.git",
"svn_url": "https://github.com/derrabus/symfony",
"homepage": "symfony.com",
"size": 49771,
"stargazers_count": 0,
"watchers_count": 0,
"language": "PHP",
"has_issues": false,
"has_downloads": false,
"has_wiki": false,
"has_pages": false,
"forks_count": 0,
"mirror_url": null,
"open_issues_count": 0,
"forks": 0,
"open_issues": 0,
"watchers": 0,
"default_branch": "master"
}
},
"base": {
"label": "symfony:2.3",
"ref": "2.3",
"sha": "1201853b55a430070d47dfba2f56629e646b17c8",
"user": {
"login": "symfony",
"id": 143937,
"avatar_url": "https://avatars.githubusercontent.com/u/143937?v=3",
"gravatar_id": "",
"url": "https://api.github.com/users/symfony",
"html_url": "https://github.com/symfony",
"followers_url": "https://api.github.com/users/symfony/followers",
"following_url": "https://api.github.com/users/symfony/following{/other_user}",
"gists_url": "https://api.github.com/users/symfony/gists{/gist_id}",
"starred_url": "https://api.github.com/users/symfony/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/symfony/subscriptions",
"organizations_url": "https://api.github.com/users/symfony/orgs",
"repos_url": "https://api.github.com/users/symfony/repos",
"events_url": "https://api.github.com/users/symfony/events{/privacy}",
"received_events_url": "https://api.github.com/users/symfony/received_events",
"type": "Organization",
"site_admin": false
},
"repo": {
"id": 458058,
"name": "symfony",
"full_name": "symfony/symfony",
"owner": {
"login": "symfony",
"id": 143937,
"avatar_url": "https://avatars.githubusercontent.com/u/143937?v=3",
"gravatar_id": "",
"url": "https://api.github.com/users/symfony",
"html_url": "https://github.com/symfony",
"followers_url": "https://api.github.com/users/symfony/followers",
"following_url": "https://api.github.com/users/symfony/following{/other_user}",
"gists_url": "https://api.github.com/users/symfony/gists{/gist_id}",
"starred_url": "https://api.github.com/users/symfony/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/symfony/subscriptions",
"organizations_url": "https://api.github.com/users/symfony/orgs",
"repos_url": "https://api.github.com/users/symfony/repos",
"events_url": "https://api.github.com/users/symfony/events{/privacy}",
"received_events_url": "https://api.github.com/users/symfony/received_events",
"type": "Organization",
"site_admin": false
},
"private": false,
"html_url": "https://github.com/symfony/symfony",
"description": "The Symfony PHP framework",
"fork": false,
"url": "https://api.github.com/repos/symfony/symfony",
"forks_url": "https://api.github.com/repos/symfony/symfony/forks",
"keys_url": "https://api.github.com/repos/symfony/symfony/keys{/key_id}",
"collaborators_url": "https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}",
"teams_url": "https://api.github.com/repos/symfony/symfony/teams",
"hooks_url": "https://api.github.com/repos/symfony/symfony/hooks",
"issue_events_url": "https://api.github.com/repos/symfony/symfony/issues/events{/number}",
"events_url": "https://api.github.com/repos/symfony/symfony/events",
"assignees_url": "https://api.github.com/repos/symfony/symfony/assignees{/user}",
"branches_url": "https://api.github.com/repos/symfony/symfony/branches{/branch}",
"tags_url": "https://api.github.com/repos/symfony/symfony/tags",
"blobs_url": "https://api.github.com/repos/symfony/symfony/git/blobs{/sha}",
"git_tags_url": "https://api.github.com/repos/symfony/symfony/git/tags{/sha}",
"git_refs_url": "https://api.github.com/repos/symfony/symfony/git/refs{/sha}",
"trees_url": "https://api.github.com/repos/symfony/symfony/git/trees{/sha}",
"statuses_url": "https://api.github.com/repos/symfony/symfony/statuses/{sha}",
"languages_url": "https://api.github.com/repos/symfony/symfony/languages",
"stargazers_url": "https://api.github.com/repos/symfony/symfony/stargazers",
"contributors_url": "https://api.github.com/repos/symfony/symfony/contributors",
"subscribers_url": "https://api.github.com/repos/symfony/symfony/subscribers",
"subscription_url": "https://api.github.com/repos/symfony/symfony/subscription",
"commits_url": "https://api.github.com/repos/symfony/symfony/commits{/sha}",
"git_commits_url": "https://api.github.com/repos/symfony/symfony/git/commits{/sha}",
"comments_url": "https://api.github.com/repos/symfony/symfony/comments{/number}",
"issue_comment_url": "https://api.github.com/repos/symfony/symfony/issues/comments/{number}",
"contents_url": "https://api.github.com/repos/symfony/symfony/contents/{+path}",
"compare_url": "https://api.github.com/repos/symfony/symfony/compare/{base}...{head}",
"merges_url": "https://api.github.com/repos/symfony/symfony/merges",
"archive_url": "https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}",
"downloads_url": "https://api.github.com/repos/symfony/symfony/downloads",
"issues_url": "https://api.github.com/repos/symfony/symfony/issues{/number}",
"pulls_url": "https://api.github.com/repos/symfony/symfony/pulls{/number}",
"milestones_url": "https://api.github.com/repos/symfony/symfony/milestones{/number}",
"notifications_url": "https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}",
"labels_url": "https://api.github.com/repos/symfony/symfony/labels{/name}",
"releases_url": "https://api.github.com/repos/symfony/symfony/releases{/id}",
"created_at": "2010-01-04T14:21:21Z",
"updated_at": "2015-01-07T08:02:48Z",
"pushed_at": "2015-01-07T08:13:19Z",
"git_url": "git://github.com/symfony/symfony.git",
"ssh_url": "[email protected]:symfony/symfony.git",
"clone_url": "https://github.com/symfony/symfony.git",
"svn_url": "https://github.com/symfony/symfony",
"homepage": "symfony.com",
"size": 184353,
"stargazers_count": 9469,
"watchers_count": 9469,
"language": "PHP",
"has_issues": true,
"has_downloads": false,
"has_wiki": false,
"has_pages": false,
"forks_count": 3694,
"mirror_url": null,
"open_issues_count": 796,
"forks": 3694,
"open_issues": 796,
"watchers": 9469,
"default_branch": "2.7"
}
},
"_links": {
"self": {
"href": "https://api.github.com/repos/symfony/symfony/pulls/13286"
},
"html": {
"href": "https://github.com/symfony/symfony/pull/13286"
},
"issue": {
"href": "https://api.github.com/repos/symfony/symfony/issues/13286"
},
"comments": {
"href": "https://api.github.com/repos/symfony/symfony/issues/13286/comments"
},
"review_comments": {
"href": "https://api.github.com/repos/symfony/symfony/pulls/13286/comments"
},
"review_comment": {
"href": "https://api.github.com/repos/symfony/symfony/pulls/comments/{number}"
},
"commits": {
"href": "https://api.github.com/repos/symfony/symfony/pulls/13286/commits"
},
"statuses": {
"href": "https://api.github.com/repos/symfony/symfony/statuses/83aaaa98c080610c9a5b4f29ad7f22dfef3ec3e6"
}
},
"merged": false,
"mergeable": true,
"mergeable_state": "unstable",
"merged_by": null,
"comments": 7,
"review_comments": 4,
"commits": 2,
"additions": 21,
"deletions": 1,
"changed_files": 2
}
},
"public": true,
"created_at": "2015-01-07T08:13:33Z",
"org": {
"id": 143937,
"login": "symfony",
"gravatar_id": "",
"url": "https://api.github.com/orgs/symfony",
"avatar_url": "https://avatars.githubusercontent.com/u/143937?"
}
},
{
"id": "2497532044",
"type": "PushEvent",
"actor": {
"id": 47313,
"login": "fabpot",
"gravatar_id": "",
"url": "https://api.github.com/users/fabpot",
"avatar_url": "https://avatars.githubusercontent.com/u/47313?"
},
"repo": {
"id": 458058,
"name": "symfony/symfony",
"url": "https://api.github.com/repos/symfony/symfony"
},
"payload": {
"push_id": 540119383,
"size": 2,
"distinct_size": 2,
"ref": "refs/heads/2.3",
"head": "c076ba8a9a72f8950740ea3d38dbb1ee69374837",
"before": "515a3ed07eb36c3dd5e5c8f329bbaf0b1c2c075f",
"commits": [
{
"sha": "5d0b527dea185416bc9d21637b6af0a69fda1300",
"author": {
"email": "[email protected]",
"name": "Alexander M. Turek"
},
"message": "[Security] Don't destroy the session on buggy php releases.",
"distinct": true,
"url": "https://api.github.com/repos/symfony/symfony/commits/5d0b527dea185416bc9d21637b6af0a69fda1300"
},
{
"sha": "c076ba8a9a72f8950740ea3d38dbb1ee69374837",
"author": {
"email": "[email protected]",
"name": "Fabien Potencier"
},
"message": "bug #13286 [Security] Don't destroy the session on buggy php releases. (derrabus)\n\nThis PR was squashed before being merged into the 2.3 branch (closes #13286).\n\nDiscussion\n----------\n\n[Security] Don't destroy the session on buggy php releases.\n\n| Q | A\n| ------------- | ---\n| Bug fix? | yes\n| New feature? | no\n| BC breaks? | no\n| Deprecations? | no\n| Tests pass? | yes\n| Fixed tickets | #13269, #13283\n| License | MIT\n| Doc PR | none\n\nSee #13269 for the discussion. This workaround avoids destroying the old session after login on the migrate strategy when running under a php version that we know to be broken.\n\nCorresponding php bug: https://bugs.php.net/bug.php?id=63379\n\nCommits\n-------\n\n5d0b527 [Security] Don't destroy the session on buggy php releases.",
"distinct": true,
"url": "https://api.github.com/repos/symfony/symfony/commits/c076ba8a9a72f8950740ea3d38dbb1ee69374837"
}
]
},
"public": true,
"created_at": "2015-01-07T08:13:19Z",
"org": {
"id": 143937,
"login": "symfony",
"gravatar_id": "",
"url": "https://api.github.com/orgs/symfony",
"avatar_url": "https://avatars.githubusercontent.com/u/143937?"
}
},
{
"id": "2497531947",
"type": "IssueCommentEvent",
"actor": {
"id": 47313,
"login": "fabpot",
"gravatar_id": "",
"url": "https://api.github.com/users/fabpot",
"avatar_url": "https://avatars.githubusercontent.com/u/47313?"
},
"repo": {
"id": 458058,
"name": "symfony/symfony",
"url": "https://api.github.com/repos/symfony/symfony"
},
"payload": {
"action": "created",
"issue": {
"url": "https://api.github.com/repos/symfony/symfony/issues/13286",
"labels_url": "https://api.github.com/repos/symfony/symfony/issues/13286/labels{/name}",
"comments_url": "https://api.github.com/repos/symfony/symfony/issues/13286/comments",
"events_url": "https://api.github.com/repos/symfony/symfony/issues/13286/events",
"html_url": "https://github.com/symfony/symfony/pull/13286",
"id": 53519889,
"number": 13286,
"title": "[Security] Don't destroy the session on buggy php releases.",
"user": {
"login": "derrabus",
"id": 1506493,
"avatar_url": "https://avatars.githubusercontent.com/u/1506493?v=3",
"gravatar_id": "",
"url": "https://api.github.com/users/derrabus",
"html_url": "https://github.com/derrabus",
"followers_url": "https://api.github.com/users/derrabus/followers",
"following_url": "https://api.github.com/users/derrabus/following{/other_user}",
"gists_url": "https://api.github.com/users/derrabus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/derrabus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/derrabus/subscriptions",
"organizations_url": "https://api.github.com/users/derrabus/orgs",
"repos_url": "https://api.github.com/users/derrabus/repos",
"events_url": "https://api.github.com/users/derrabus/events{/privacy}",
"received_events_url": "https://api.github.com/users/derrabus/received_events",
"type": "User",
"site_admin": false
},
"labels": [
],
"state": "open",
"locked": false,
"assignee": null,
"milestone": null,
"comments": 7,
"created_at": "2015-01-06T14:31:46Z",
"updated_at": "2015-01-07T08:13:13Z",
"closed_at": null,
"pull_request": {
"url": "https://api.github.com/repos/symfony/symfony/pulls/13286",
"html_url": "https://github.com/symfony/symfony/pull/13286",
"diff_url": "https://github.com/symfony/symfony/pull/13286.diff",
"patch_url": "https://github.com/symfony/symfony/pull/13286.patch"
},
"body": "| Q | A\r\n| ------------- | ---\r\n| Bug fix? | yes\r\n| New feature? | no\r\n| BC breaks? | no\r\n| Deprecations? | no\r\n| Tests pass? | yes\r\n| Fixed tickets | #13269, #13283\r\n| License | MIT\r\n| Doc PR | none\r\n\r\nSee #13269 for the discussion. This workaround avoids destroying the old session after login on the migrate strategy when running under a php version that we know to be broken.\r\n\r\nCorresponding php bug: https://bugs.php.net/bug.php?id=63379"
},
"comment": {
"url": "https://api.github.com/repos/symfony/symfony/issues/comments/68990627",
"html_url": "https://github.com/symfony/symfony/pull/13286#issuecomment-68990627",
"issue_url": "https://api.github.com/repos/symfony/symfony/issues/13286",
"id": 68990627,
"user": {
"login": "fabpot",
"id": 47313,
"avatar_url": "https://avatars.githubusercontent.com/u/47313?v=3",
"gravatar_id": "",
"url": "https://api.github.com/users/fabpot",
"html_url": "https://github.com/fabpot",
"followers_url": "https://api.github.com/users/fabpot/followers",
"following_url": "https://api.github.com/users/fabpot/following{/other_user}",
"gists_url": "https://api.github.com/users/fabpot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fabpot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fabpot/subscriptions",
"organizations_url": "https://api.github.com/users/fabpot/orgs",
"repos_url": "https://api.github.com/users/fabpot/repos",
"events_url": "https://api.github.com/users/fabpot/events{/privacy}",
"received_events_url": "https://api.github.com/users/fabpot/received_events",
"type": "User",
"site_admin": false
},
"created_at": "2015-01-07T08:13:13Z",
"updated_at": "2015-01-07T08:13:13Z",
"body": "Thank you @derrabus."
}
},
"public": true,
"created_at": "2015-01-07T08:13:14Z",
"org": {
"id": 143937,
"login": "symfony",
"gravatar_id": "",
"url": "https://api.github.com/orgs/symfony",
"avatar_url": "https://avatars.githubusercontent.com/u/143937?"
}
},
{
"id": "2497531550",
"type": "IssueCommentEvent",
"actor": {
"id": 47313,
"login": "fabpot",
"gravatar_id": "",
"url": "https://api.github.com/users/fabpot",
"avatar_url": "https://avatars.githubusercontent.com/u/47313?"
},
"repo": {
"id": 458058,
"name": "symfony/symfony",
"url": "https://api.github.com/repos/symfony/symfony"
},
"payload": {
"action": "created",
"issue": {
"url": "https://api.github.com/repos/symfony/symfony/issues/13241",
"labels_url": "https://api.github.com/repos/symfony/symfony/issues/13241/labels{/name}",
"comments_url": "https://api.github.com/repos/symfony/symfony/issues/13241/comments",
"events_url": "https://api.github.com/repos/symfony/symfony/issues/13241/events",
"html_url": "https://github.com/symfony/symfony/pull/13241",
"id": 53337109,
"number": 13241,
"title": "[Form] add back model_timezone and view_timezone options",
"user": {
"login": "xabbuh",
"id": 1957048,
"avatar_url": "https://avatars.githubusercontent.com/u/1957048?v=3",
"gravatar_id": "",
"url": "https://api.github.com/users/xabbuh",
"html_url": "https://github.com/xabbuh",
"followers_url": "https://api.github.com/users/xabbuh/followers",
"following_url": "https://api.github.com/users/xabbuh/following{/other_user}",
"gists_url": "https://api.github.com/users/xabbuh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/xabbuh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/xabbuh/subscriptions",
"organizations_url": "https://api.github.com/users/xabbuh/orgs",
"repos_url": "https://api.github.com/users/xabbuh/repos",
"events_url": "https://api.github.com/users/xabbuh/events{/privacy}",
"received_events_url": "https://api.github.com/users/xabbuh/received_events",
"type": "User",
"site_admin": false
},
"labels": [
],
"state": "open",
"locked": false,
"assignee": null,
"milestone": null,
"comments": 5,
"created_at": "2015-01-04T13:59:52Z",
"updated_at": "2015-01-07T08:12:52Z",
"closed_at": null,
"pull_request": {
"url": "https://api.github.com/repos/symfony/symfony/pulls/13241",
"html_url": "https://github.com/symfony/symfony/pull/13241",
"diff_url": "https://github.com/symfony/symfony/pull/13241.diff",
"patch_url": "https://github.com/symfony/symfony/pull/13241.patch"
},
"body": "| Q | A\r\n| ------------- | ---\r\n| Bug fix? | yes\r\n| New feature? | no\r\n| BC breaks? | no\r\n| Deprecations? | no\r\n| Tests pass? | yes\r\n| Fixed tickets | #13224 \r\n| License | MIT\r\n| Doc PR | TODO (deprecate the `model_timezone` and `view_timezone` options)\r\n\r\nThis reverts #12404."
},
"comment": {
"url": "https://api.github.com/repos/symfony/symfony/issues/comments/68990598",
"html_url": "https://github.com/symfony/symfony/pull/13241#issuecomment-68990598",
"issue_url": "https://api.github.com/repos/symfony/symfony/issues/13241",
"id": 68990598,
"user": {
"login": "fabpot",
"id": 47313,
"avatar_url": "https://avatars.githubusercontent.com/u/47313?v=3",
"gravatar_id": "",
"url": "https://api.github.com/users/fabpot",
"html_url": "https://github.com/fabpot",
"followers_url": "https://api.github.com/users/fabpot/followers",
"following_url": "https://api.github.com/users/fabpot/following{/other_user}",
"gists_url": "https://api.github.com/users/fabpot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fabpot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fabpot/subscriptions",
"organizations_url": "https://api.github.com/users/fabpot/orgs",
"repos_url": "https://api.github.com/users/fabpot/repos",
"events_url": "https://api.github.com/users/fabpot/events{/privacy}",
"received_events_url": "https://api.github.com/users/fabpot/received_events",
"type": "User",
"site_admin": false
},
"created_at": "2015-01-07T08:12:52Z",
"updated_at": "2015-01-07T08:12:52Z",
"body": "I'm going to merge this one today to be able to release 2.6.2. Any other feedback before the merge?"
}
},
"public": true,
"created_at": "2015-01-07T08:12:53Z",
"org": {
"id": 143937,
"login": "symfony",
"gravatar_id": "",
"url": "https://api.github.com/orgs/symfony",
"avatar_url": "https://avatars.githubusercontent.com/u/143937?"
}
},
{
"id": "2497523659",
"type": "PullRequestReviewCommentEvent",
"actor": {
"id": 47313,
"login": "fabpot",
"gravatar_id": "",
"url": "https://api.github.com/users/fabpot",
"avatar_url": "https://avatars.githubusercontent.com/u/47313?"
},
"repo": {
"id": 458058,
"name": "symfony/symfony",
"url": "https://api.github.com/repos/symfony/symfony"
},
"payload": {
"action": "created",
"comment": {
"url": "https://api.github.com/repos/symfony/symfony/pulls/comments/22574553",
"id": 22574553,
"diff_hunk": "@@ -103,4 +109,16 @@ public function getPriority()\n {\n return -10;\n }\n+\n+ /**\n+ * @return bool\n+ */\n+ private function isNamedArguments($arguments)\n+ {\n+ foreach ($arguments as $name => $node) {\n+ return !is_int($name);",
"path": "src/Symfony/Bridge/Twig/NodeVisitor/TranslationDefaultDomainNodeVisitor.php",
"position": 37,
"original_position": 37,
"commit_id": "71b6fe018ff679c9ca651b43ac3f02eb2b7136a2",
"original_commit_id": "71b6fe018ff679c9ca651b43ac3f02eb2b7136a2",
"user": {
"login": "fabpot",
"id": 47313,
"avatar_url": "https://avatars.githubusercontent.com/u/47313?v=3",
"gravatar_id": "",
"url": "https://api.github.com/users/fabpot",
"html_url": "https://github.com/fabpot",
"followers_url": "https://api.github.com/users/fabpot/followers",
"following_url": "https://api.github.com/users/fabpot/following{/other_user}",
"gists_url": "https://api.github.com/users/fabpot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fabpot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fabpot/subscriptions",
"organizations_url": "https://api.github.com/users/fabpot/orgs",
"repos_url": "https://api.github.com/users/fabpot/repos",
"events_url": "https://api.github.com/users/fabpot/events{/privacy}",
"received_events_url": "https://api.github.com/users/fabpot/received_events",
"type": "User",
"site_admin": false
},
"body": "This looks wrong to me as you always return during the first iteration.",
"created_at": "2015-01-07T08:05:37Z",
"updated_at": "2015-01-07T08:05:37Z",
"html_url": "https://github.com/symfony/symfony/pull/13250#discussion_r22574553",
"pull_request_url": "https://api.github.com/repos/symfony/symfony/pulls/13250",
"_links": {
"self": {
"href": "https://api.github.com/repos/symfony/symfony/pulls/comments/22574553"
},
"html": {
"href": "https://github.com/symfony/symfony/pull/13250#discussion_r22574553"
},
"pull_request": {
"href": "https://api.github.com/repos/symfony/symfony/pulls/13250"