BLE Support

[vovagorodok]

Any plans to add support OTA over BLE?
Found this one: https://github.com/fbiego/ESP32_BLE_OTA_Arduino
Will be nice to have here such functionality

[JAndrassy]

Any plans to add support OTA over BLE? Found this one: https://github.com/fbiego/ESP32_BLE_OTA_Arduino Will be nice to have here such functionality

just use InternalStorage object from this library instead of the esp32 Update object

[vovagorodok]

Decided to create Arduino library that base on ArduinoOTA:
https://github.com/vovagorodok/ArduinoBleOTA

In order to use OTAStorage is needed to copy all includes:

#ifdef __AVR__
#if FLASHEND >= 0xFFFF
#include "InternalStorageAVR.h"
#endif
#elif defined(STM32F1xx)
#include <InternalStorageSTM32.h>
#elif defined(ARDUINO_ARCH_RP2040)
#include <InternalStorageRP2.h>
#elif defined(ESP8266) || defined(ESP32)
#include "InternalStorageESP.h"
#else
#include "InternalStorage.h"
#endif
#ifdef __SD_H__
#include "SDStorage.h"
SDStorageClass SDStorage;
#endif
#ifdef SerialFlash_h_
#include "SerialFlashStorage.h"
SerialFlashStorageClass SerialFlashStorage;
#endif

here: https://github.com/vovagorodok/ArduinoBleOTA/blob/main/src/OTAStorage.h

Can that includes be moved to separate include file? (it helps to easy maintain BleOTA)

[JAndrassy]

you would have to copy everything except of ArduinoOTA.h and WiFiOTA.cpp/.h.
better use the ArduinoOTA library as dependency.
put

depends=ArduinoOTA

into library.properties of your library

[vovagorodok]

Currently it's arduino program instead of library. I use ArduinoOTA as dependency:
https://github.com/vovagorodok/ArduinoBleOTA/blob/main/platformio.ini
Nothing is copied except lines with defines of storage.

But in order to have the same interface as ArduinoOTA, I need this includes. When I include ArduinoOTA.h, Wifi library is included to. Will be nice create separate OTAStorageDefinitions.h with content:

#pragma once

#ifdef __AVR__
#if FLASHEND >= 0xFFFF
#include "InternalStorageAVR.h"
#endif
#elif defined(STM32F1xx)
#include <InternalStorageSTM32.h>
#elif defined(ARDUINO_ARCH_RP2040)
#include <InternalStorageRP2.h>
#elif defined(ESP8266) || defined(ESP32)
#include "InternalStorageESP.h"
#else
#include "InternalStorage.h"
#endif
#ifdef __SD_H__
#include "SDStorage.h"
SDStorageClass SDStorage;
#endif
#ifdef SerialFlash_h_
#include "SerialFlashStorage.h"
SerialFlashStorageClass SerialFlashStorage;
#endif

and include it in ArduinoOTA.h:

#ifndef _ARDUINOOTA_H_
#define _ARDUINOOTA_H_

#include "WiFiOTA.h"
#include "OTAStorageDefinitions.h"

const uint16_t OTA_PORT = 65280;

template <class NetServer, class NetClient>
class ArduinoOTAClass : public WiFiOTAClass {
...

and I'll include only storage definitions without wifi in BleOTA.h:

#pragma once
#include <NimBLEDevice.h>
#include "OTAStorageDefinitions.h"

class BleOTAClass: public BLECharacteristicCallbacks
{
...

[JAndrassy]

have OTAStorageDefinitions.h in your library.

[vovagorodok]

It 'will be copy-pasta of ArduinoOTA code. I would avoid it, if it's possible

[JAndrassy]

it is not a problem since maybe it will not even be the same set of supported platforms

[vovagorodok]

But if something will changed in OTAStorageDefinitions of ArduinoOTA repo, I should align BleOta repo each time (additional maintenance). Better to support all platforms from internal storage PoV, and have it abstract, it helps easily extend BleOta in future