Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Fix issue 2572 - GitHub Backups Requirements Card #2575

Merged
merged 8 commits into from
Sep 4, 2023
Merged

Fix issue 2572 - GitHub Backups Requirements Card #2575

merged 8 commits into from
Sep 4, 2023

Conversation

nicolegeorgieva
Copy link
Contributor

@nicolegeorgieva nicolegeorgieva commented Sep 4, 2023 •
edited
Loading

Pull Request (PR) Checklist

Please check if your pull request fulfills the following requirements:

  • The PR is submitted to the main branch.
  • I've read the Contribution Guidelines.
  • The code builds and is tested on a real Android device.
  • I confirm that I've run the code locally and everything works as expected.

What's changed?

Describe with a few bullets what's new:

  • All the requirements for the auto backups to work are now available on the GitHubBackupScreen in a Warning card
Light Dark
Screenshot_20230904_182708 Screenshot_20230904_182750

Does this PR closes any GitHub Issues?

ILIYANGERMANOV
ILIYANGERMANOV approved these changes Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One minor issue about touched code in AndroidManifest

app/src/main/AndroidManifest.xml Show resolved Hide resolved
@ILIYANGERMANOV ILIYANGERMANOV merged commit cb263a0 into Ivy-Apps:main Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ILIYANGERMANOV ILIYANGERMANOV ILIYANGERMANOV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] GitHub Backups Requirements Card
2 participants
@nicolegeorgieva @ILIYANGERMANOV