diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index ba7f073466..a2e2504993 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,7 +1,5 @@ ## Pull Request (PR) Checklist - Please check if your pull request fulfills the following requirements: - - [ ] The PR is submitted to the `develop` branch. - [ ] I've read the **[Contribution Guidelines](https://github.com/ILIYANGERMANOV/ivy-wallet/blob/main/CONTRIBUTING.md)**. - [ ] The code builds and is tested on an actual Android device. @@ -12,41 +10,16 @@ Please check if your pull request fulfills the following requirements: _Important: Don't worry if you experience flaky UI tests. Just re-run the failed ones again and if they pass => it's all good!_ _Put an `x` in the boxes that apply._ - - [x] Demo: Checking checkbox using `[x]` -### How to run Ivy Wallet's UI tests (`androidTest`) - -**Connect Android Emulator** -- Pixel 5 API 29+ AVD emulator _(recommended)_ -- Pixel 3XL API 29+ AVD emulator _(recommended)_ -- Large screen physical device _(might also work)_ - -**Method 1: Android Studio UI** -- Find `com (androidTest)` package -- Right click -- `Run 'Tests in 'com''` - -_Note: If you've checked "Compact Middle Packages" the option will appear as `com.ivy.wallet (androidTest)`._ - -**Method 2: Gradle Wrapper** -- `chmod +x gradlew` (Linux) -- `./gradlew connectedDebugAndroidTest` - -**Method 3: Fastlane** -- Install Ruby 2.7 -- `bundle install` -- `bundle exec fastlane ui_tests` ## Pull Request Type - Please check the type of change your PR introduces: - - [ ] Bugfix - [ ] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes) -- [ ] Small update (fix typo, UI fine-tune, change color or something small) +- [ ] Small improvement (fix typo, UI fine-tune, change color or something small) - [ ] Gradle Build related changes - [ ] Dependencies update (updating libraries) - [ ] Documentation @@ -55,8 +28,8 @@ Please check the type of change your PR introduces: _Put an `x` in the boxes that apply._ -## Does this PR closes any GitHub Issues? +## Does this PR closes any GitHub Issues? Check **[Ivy Wallet Issues](https://github.com/ILIYANGERMANOV/ivy-wallet/issues)**. - Closes #N/A (type issue number here) @@ -64,9 +37,35 @@ Check **[Ivy Wallet Issues](https://github.com/ILIYANGERMANOV/ivy-wallet/issues) ## What's changed? Describe with a few bullets **what's new:** - - + - - -_This PR template style was inspired by [ionic-framework](https://github.com/ionic-team/ionic-framework/blob/main/.github/PULL_REQUEST_TEMPLATE.md)._ \ No newline at end of file +## How to run Ivy Wallet's UI tests (`androidTest`) + +**Connect Android Emulator** + +- Pixel 5 API 29+ AVD emulator _(recommended)_ +- Pixel 3XL API 29+ AVD emulator _(recommended)_ +- Large screen physical device _(might also work)_ + +**Method 1: Android Studio UI** + +- Find `com (androidTest)` package +- Right click +- `Run 'Tests in 'com''` + +_Note: If you've checked "Compact Middle Packages" the option will appear +as `com.ivy.wallet (androidTest)`._ + +**Method 2: Gradle Wrapper** + +- `chmod +x gradlew` (Linux) +- `./gradlew connectedDebugAndroidTest` + +**Method 3: Fastlane** + +- Install Ruby 2.7 +- `bundle install` +- `bundle exec fastlane ui_tests` \ No newline at end of file