Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should add IPFS attribute file URI to Data NFTs created + remove the data stream "url" type checks #40

Closed
damienen opened this issue Mar 2, 2023 · 1 comment
Closed

Should add IPFS attribute file URI to Data NFTs created + remove the data stream "url" type checks #40

damienen opened this issue Mar 2, 2023 · 1 comment
Assignees
@bucurdavid
Labels
enhancement New feature or request

Comments

@damienen
Copy link
Member

damienen commented Mar 2, 2023 •
edited by newbreedofgeek
Loading

Related to: Itheum/data-dex#333

Should ask for the CID and create the ipfs link inside the SC.

AND:

Related to : Itheum/data-dex#360
SC should not check Data Steam URL length
@damienen damienen added the enhancement New feature or request label Mar 2, 2023
bucurdavid added a commit that referenced this issue Mar 10, 2023
@bucurdavid
Implemented #40
5eaf17d
bucurdavid added a commit that referenced this issue Mar 15, 2023
@bucurdavid
Revert " Implemented #40"
e4edb33 
This reverts commit 5eaf17d.
bucurdavid added a commit that referenced this issue Mar 15, 2023
@bucurdavid
Implemented #40
1609717
@newbreedofgeek newbreedofgeek changed the title Should add IPFS attribute file URI to Data NFTs created Should add IPFS attribute file URI to Data NFTs created + remove the data stream "url" type checks Mar 16, 2023
newbreedofgeek added a commit that referenced this issue Mar 16, 2023
@newbreedofgeek
tested, reviewed and deployed to devnet #40. ready for main
a8aaebc
@newbreedofgeek newbreedofgeek mentioned this issue Mar 16, 2023
Merged
damienen added a commit that referenced this issue Mar 16, 2023
@damienen
Merge pull request #42 from Itheum/d-mark
629d93d 
IPFS attribute file URI + remove the data stream "url" type checks (#40)
@damienen
Copy link
Member Author

Solved. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bucurdavid bucurdavid

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@damienen @bucurdavid