Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.2.1 fixes #120

Merged
merged 10 commits into from
Jul 21, 2021
Merged

v1.2.1 fixes #120

merged 10 commits into from
Jul 21, 2021

Conversation

skjiisa
Copy link
Owner

@skjiisa skjiisa commented Dec 14, 2020

Fix issues with delete functions and make them properly supported (deleting each item from the Index Set).

@skjiisa
Copy link
Owner Author

skjiisa commented Dec 14, 2020

Not relevant to SwiftUI delete functionality, but I'm also going to use this branch and pull request to add library acknowledgements.

@skjiisa skjiisa changed the title Swiftui delete SwiftUI Delete Dec 14, 2020
@skjiisa skjiisa linked an issue Dec 14, 2020 that may be closed by this pull request
@skjiisa skjiisa changed the title SwiftUI Delete v1.2.1 bug fixes Dec 14, 2020
@skjiisa skjiisa changed the title v1.2.1 bug fixes v1.2.1 fixes Dec 14, 2020
@skjiisa
Copy link
Owner Author

skjiisa commented Dec 14, 2020

This last commit to allow relationships to be marked as required should fix #104.

If users already have existing hidden objects (such as modules with no games or no type), those will still remain.
I could potentially add a startup script in preloadData() to remove any objects with missing requirements.
I might not though tbh because it's not going to be a major issue and I can't imagine anyone's actually gone out of their way to make their own invalid QR codes and scanned them.

@skjiisa skjiisa linked an issue Dec 15, 2020 that may be closed by this pull request
@skjiisa skjiisa merged commit 1a55c6f into master Jul 21, 2021
@skjiisa skjiisa deleted the swiftui-delete branch July 21, 2021 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant