Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow drupal/filehash:^3 #1005

Closed
kayakr opened this issue Jan 31, 2024 · 2 comments
Closed

Allow drupal/filehash:^3 #1005

kayakr opened this issue Jan 31, 2024 · 2 comments

Comments

@kayakr
Copy link

kayakr commented Jan 31, 2024

Filehash 3.0.1 is out https://www.drupal.org/project/filehash/releases/3.0.1

Islandora is hard-coded in composer.json to only support filehash:^2 https://github.com/Islandora/islandora/blob/2.x/composer.json#L21

I suggest supporting both, e.g. filehash: ^2 || ^3

@rosiel
Copy link
Member

rosiel commented Jan 31, 2024

I was bitten by not testing the previous major update of filehash properly.

So I just want to outline what needs to be tested:

When we update a file (/media), islandora code tests whether the filehash has changed, and does not run derivatives if it's got the same sha1.

The code: https://github.com/Islandora/islandora/blob/2.11.0/islandora.module#L185-L188

@jordandukart
Copy link
Member

Closing as this merged in #1016.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants