Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Islandora weight doesn't let you reorder children #2076

Closed
rosiel opened this issue Apr 4, 2022 · 6 comments
Closed

Islandora weight doesn't let you reorder children #2076

rosiel opened this issue Apr 4, 2022 · 6 comments
Labels
Type: bug identifies a problem in the software with clear steps to reproduce

Comments

@rosiel
Copy link
Member

rosiel commented Apr 4, 2022

The integer weight fields don't seem to work if content wasn't created from the Add Members tab.

To replicate:

  1. create a paged content item
  2. create two or more page items from the global add content interface (i.e. not from the Members tab)
  3. In the member of field, point the pages to the paged content.
  4. Go to the paged content item's members tab and attempt to re-order children.

My results were that dragging the bottom child to the top took no effect (pressing Save caused it to revert to the bottom). With "View weights" on, I could see that both of them were weight 1 and the dropdown gave me no option to change the value.
Screen Shot 2022-04-04 at 4 08 16 PM

@amyrb
Copy link
Contributor

amyrb commented Apr 4, 2022

In the context of compound objects rather than paged content, I have been able to reorder children by editing each of the child objects and setting the weight there. The problem you describe clearly needs fixing, but setting the weight directly by editing the child node might be a workaround? (Unless it isn't?)

@kstapelfeldt kstapelfeldt added the Type: bug identifies a problem in the software with clear steps to reproduce label Apr 5, 2022
@seth-shaw-unlv
Copy link
Contributor

I believe this PR provided a fix for this. Could you double-check to make sure you have the latest 2.x code for islandora and try again?

@rosiel
Copy link
Member Author

rosiel commented Apr 5, 2022

It did. [edit: It fixed it. I did not have the latest 2.x code.] Would it be possible to tag a bugfix or greater release of the 2.x code? It appears to have been 6 months since our last tag.

@seth-shaw-unlv
Copy link
Contributor

Sure. Give me a few minutes to finish testing Islandora/islandora#865 and then I can do that.

@seth-shaw-unlv
Copy link
Contributor

Repository owner moved this from Todo to Done in Islandora Issues Queue Apr 5, 2022
@rosiel
Copy link
Member Author

rosiel commented Apr 5, 2022

also thank you @amyrb that was a smart workaround. I had the "Custom sort weight" hidden inside an accordion fold and didn't notice it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug identifies a problem in the software with clear steps to reproduce
Projects
Development

No branches or pull requests

4 participants