Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to find a place in the docs navigation Islandora 2 release notes #2063

Closed
ysuarez opened this issue Mar 16, 2022 · 5 comments
Closed

Need to find a place in the docs navigation Islandora 2 release notes #2063

ysuarez opened this issue Mar 16, 2022 · 5 comments

Comments

@ysuarez
Copy link
Contributor

ysuarez commented Mar 16, 2022

This issue was suggested by @seth-shaw-unlv.

We need to find a place in the navigation for spot for current and future Islandora 2 release notes, sicne right now there is no direct link from the docs (as far as we know). You would need to traverse the github repo to find the release notes.

Here is the only one and current release notes on the repo:

https://github.com/Islandora/documentation/blob/main/docs/release_notes/8.x-2.0.md

My first suggestion for a spot for it in the navigation is at the top of the "Installation" section in mkdocs.yml before line 72...

documentation/mkdocs.yml

Lines 67 to 73 in 3273e1a

- Installation:
# Procedural, different user roles: clarify who the audience is for a
# particular recipe. The ISLE documentation page was written with a
# 'non-technical' user in mind who wants to test. The Manual installation
# guides mention that users will need additional knowledge about server administration.
- 'Docker (ISLE)':
- 'Introduction to ISLE': 'installation/docker-introduction.md'

I am thinking something like this...

  - Installation:
      # Procedural, different user roles: clarify who the audience is for a
      # particular recipe. The ISLE documentation page was written with a
      # 'non-technical' user in mind who wants to test. The Manual installation
      # guides mention that users will need additional knowledge about server administration.
      - 'Release Notes': 'release_notes/8.x-2.0.md'
          - 'Older Release Notes': 'release_notes/'
      - 'Docker (ISLE)':
          - 'Introduction to ISLE': 'installation/docker-introduction.md'

Though other may have better ideas and look forward to hearing them.
@Islandora/documentation @Islandora/8-x-committers

@eldonquijote
Copy link
Contributor

This is probably an oversight, since all documentation pages should be linked from the menu tree.

In this case, they could be linked from different places in the menu, but I like the suggestion to add them to the "Installation" section for starters.

@ysuarez
Copy link
Contributor Author

ysuarez commented Mar 23, 2022

@eldonquijote thanks for the feedback. I am creating a PR for this since you thought it would be an OK place for it (at least for now).

Also, when building the docs locally the software listed the release file I am now linking as not being reflected in the navigation at all. Now that I have linked to the release notes locally, the Mkdocs software says these additional files are also not linked in the navigation. I am going to list them here to document them, so I or someone else can check if they also need to be linked from the navigation...

<snip>
INFO    -  The following pages exist in the docs directory, but are not included in the "nav" configuration:
  - placeholder.md
  - contributing/readme_template.md
  - installation/docker-download.md
  - tutorials/switch_homepage_to_twig.md
  - user-documentation/recipes/alexa_search.md 
<snip>

@rosiel
Copy link
Member

rosiel commented Mar 24, 2022

since the release notes are in the menu now, is it okay to close this ticket?

@eldonquijote
Copy link
Contributor

- user-documentation/recipes/alexa_search.md is linked from the page "Extending Islandora" (aka cookbook)
- placeholder.md is practically empty
- installation/docker-download.md is empty

- tutorials/switch_homepage_to_twig.md could be linked from the Cookbook as well, although I'm not sure whether the described steps are optional, or should actually be best practice if Twig is the default templating mechanism in D8..?
- contributing/readme_template.md - unclear where that should be linked from

@ysuarez
Copy link
Contributor Author

ysuarez commented Mar 25, 2022

¡Thanks @rosiel!

I am going to close this ticket and open a new one for the "unlinked" files I ran into, in case they need follow up.

@ysuarez ysuarez closed this as completed Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants